This is an archive of the discontinued LLVM Phabricator instance.

Differential D142518

[libc] Implement strcasestr
ClosedPublic

Authored by abrachet on Jan 24 2023, 4:27 PM.

Details

Reviewers
michaelrj
sivachandra
lntue
Commits
rG741021de3236: [libc] Implement strcasestr

Diff Detail

Event Timeline

abrachet created this revision.Jan 24 2023, 4:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 4:27 PM
Herald added subscribers: ecnelises, tschuett. · View Herald Transcript
abrachet requested review of this revision.Jan 24 2023, 4:27 PM
abrachet added a parent revision: D142517: [libc] Templatize strstr.
abrachet edited subscribers, added: libc-commits; removed: llvm-commits.
Harbormaster completed remote builds in B209779: Diff 491955.Jan 24 2023, 4:58 PM
lntue accepted this revision.Jan 25 2023, 7:15 AM
This revision is now accepted and ready to land.Jan 25 2023, 7:15 AM
sivachandra accepted this revision.Jan 25 2023, 8:33 AM
Closed by commit rG741021de3236: [libc] Implement strcasestr (authored by abrachet). · Explain WhyJan 25 2023, 9:58 AM
This revision was automatically updated to reflect the committed changes.
abrachet added a commit: rG741021de3236: [libc] Implement strcasestr.
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2023, 9:58 AM

Revision Contents

PathSize
libc/
config/
baremetal/
1 line
darwin/
arm/
1 line
gpu/
1 line
linux/
aarch64/
1 line
arm/
1 line
x86_64/
1 line
windows/
1 line
spec/
5 lines
src/
string/
11 lines
18 lines
28 lines
test/
src/
string/
10 lines
24 lines

Diff 491955

libc/config/baremetal/entrypoints.txt

Show All 26 Linesset(TARGET_LIBC_ENTRYPOINTS
libc.src.string.memcpy libc.src.string.memcpy
libc.src.string.memmove libc.src.string.memmove
libc.src.string.mempcpy libc.src.string.mempcpy
libc.src.string.memrchr libc.src.string.memrchr
libc.src.string.memset libc.src.string.memset
libc.src.string.stpcpy libc.src.string.stpcpy
libc.src.string.stpncpy libc.src.string.stpncpy
libc.src.string.strcasecmp libc.src.string.strcasecmp
libc.src.string.strcasestr
libc.src.string.strcat libc.src.string.strcat
libc.src.string.strchr libc.src.string.strchr
libc.src.string.strcmp libc.src.string.strcmp
libc.src.string.strcpy libc.src.string.strcpy
libc.src.string.strcspn libc.src.string.strcspn
libc.src.string.strlcat libc.src.string.strlcat
libc.src.string.strlcpy libc.src.string.strlcpy
libc.src.string.strlen libc.src.string.strlen
▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines

libc/config/darwin/arm/entrypoints.txt

Show All 26 Linesset(TARGET_LIBC_ENTRYPOINTS
libc.src.string.memcpy libc.src.string.memcpy
libc.src.string.memmove libc.src.string.memmove
libc.src.string.mempcpy libc.src.string.mempcpy
libc.src.string.memrchr libc.src.string.memrchr
libc.src.string.memset libc.src.string.memset
libc.src.string.stpcpy libc.src.string.stpcpy
libc.src.string.stpncpy libc.src.string.stpncpy
libc.src.string.strcasecmp libc.src.string.strcasecmp
libc.src.string.strcasestr
libc.src.string.strcat libc.src.string.strcat
libc.src.string.strchr libc.src.string.strchr
libc.src.string.strcmp libc.src.string.strcmp
libc.src.string.strcpy libc.src.string.strcpy
libc.src.string.strcspn libc.src.string.strcspn
libc.src.string.strlcat libc.src.string.strlcat
libc.src.string.strlcpy libc.src.string.strlcpy
libc.src.string.strlen libc.src.string.strlen
▲ Show 20 Lines • Show All 172 Lines • Show Last 20 Lines

libc/config/gpu/entrypoints.txt

Show All 25 Linesset(TARGET_LIBC_ENTRYPOINTS
libc.src.string.memcpy libc.src.string.memcpy
libc.src.string.memmove libc.src.string.memmove
libc.src.string.mempcpy libc.src.string.mempcpy
libc.src.string.memrchr libc.src.string.memrchr
libc.src.string.memset libc.src.string.memset
libc.src.string.stpcpy libc.src.string.stpcpy
libc.src.string.stpncpy libc.src.string.stpncpy
libc.src.string.strcasecmp libc.src.string.strcasecmp
libc.src.string.strcasestr
libc.src.string.strcat libc.src.string.strcat
libc.src.string.strchr libc.src.string.strchr
libc.src.string.strcmp libc.src.string.strcmp
libc.src.string.strcpy libc.src.string.strcpy
libc.src.string.strcspn libc.src.string.strcspn
libc.src.string.strlcat libc.src.string.strlcat
libc.src.string.strlcpy libc.src.string.strlcpy
libc.src.string.strlen libc.src.string.strlen
Show All 17 Lines

libc/config/linux/aarch64/entrypoints.txt

Show All 35 Linesset(TARGET_LIBC_ENTRYPOINTS
libc.src.string.memcpy libc.src.string.memcpy
libc.src.string.memmove libc.src.string.memmove
libc.src.string.mempcpy libc.src.string.mempcpy
libc.src.string.memrchr libc.src.string.memrchr
libc.src.string.memset libc.src.string.memset
libc.src.string.stpcpy libc.src.string.stpcpy
libc.src.string.stpncpy libc.src.string.stpncpy
libc.src.string.strcasecmp libc.src.string.strcasecmp
libc.src.string.strcasestr
libc.src.string.strcat libc.src.string.strcat
libc.src.string.strchr libc.src.string.strchr
libc.src.string.strcmp libc.src.string.strcmp
libc.src.string.strcpy libc.src.string.strcpy
libc.src.string.strcspn libc.src.string.strcspn
libc.src.string.strdup libc.src.string.strdup
libc.src.string.strerror libc.src.string.strerror
libc.src.string.strerror_r libc.src.string.strerror_r
▲ Show 20 Lines • Show All 405 Lines • Show Last 20 Lines

libc/config/linux/arm/entrypoints.txt

Show All 26 Linesset(TARGET_LIBC_ENTRYPOINTS
libc.src.string.memcpy libc.src.string.memcpy
libc.src.string.memmove libc.src.string.memmove
libc.src.string.mempcpy libc.src.string.mempcpy
libc.src.string.memrchr libc.src.string.memrchr
libc.src.string.memset libc.src.string.memset
libc.src.string.stpcpy libc.src.string.stpcpy
libc.src.string.stpncpy libc.src.string.stpncpy
libc.src.string.strcasecmp libc.src.string.strcasecmp
libc.src.string.strcasestr
libc.src.string.strcat libc.src.string.strcat
libc.src.string.strchr libc.src.string.strchr
libc.src.string.strcmp libc.src.string.strcmp
libc.src.string.strcpy libc.src.string.strcpy
libc.src.string.strcspn libc.src.string.strcspn
libc.src.string.strlcat libc.src.string.strlcat
libc.src.string.strlcpy libc.src.string.strlcpy
libc.src.string.strlen libc.src.string.strlen
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines

libc/config/linux/x86_64/entrypoints.txt

Show All 35 Linesset(TARGET_LIBC_ENTRYPOINTS
libc.src.string.memcpy libc.src.string.memcpy
libc.src.string.memmove libc.src.string.memmove
libc.src.string.mempcpy libc.src.string.mempcpy
libc.src.string.memrchr libc.src.string.memrchr
libc.src.string.memset libc.src.string.memset
libc.src.string.stpcpy libc.src.string.stpcpy
libc.src.string.stpncpy libc.src.string.stpncpy
libc.src.string.strcasecmp libc.src.string.strcasecmp
libc.src.string.strcasestr
libc.src.string.strcat libc.src.string.strcat
libc.src.string.strchr libc.src.string.strchr
libc.src.string.strcmp libc.src.string.strcmp
libc.src.string.strcoll libc.src.string.strcoll
libc.src.string.strcpy libc.src.string.strcpy
libc.src.string.strcspn libc.src.string.strcspn
libc.src.string.strdup libc.src.string.strdup
libc.src.string.strerror libc.src.string.strerror
▲ Show 20 Lines • Show All 444 Lines • Show Last 20 Lines

libc/config/windows/entrypoints.txt

Show All 26 Linesset(TARGET_LIBC_ENTRYPOINTS
libc.src.string.memcpy libc.src.string.memcpy
libc.src.string.memmove libc.src.string.memmove
libc.src.string.mempcpy libc.src.string.mempcpy
libc.src.string.memrchr libc.src.string.memrchr
libc.src.string.memset libc.src.string.memset
libc.src.string.stpcpy libc.src.string.stpcpy
libc.src.string.stpncpy libc.src.string.stpncpy
libc.src.string.strcasecmp libc.src.string.strcasecmp
libc.src.string.strcasestr
libc.src.string.strcat libc.src.string.strcat
libc.src.string.strchr libc.src.string.strchr
libc.src.string.strcmp libc.src.string.strcmp
libc.src.string.strcpy libc.src.string.strcpy
libc.src.string.strcspn libc.src.string.strcspn
libc.src.string.strlcat libc.src.string.strlcat
libc.src.string.strlcpy libc.src.string.strlcpy
libc.src.string.strlen libc.src.string.strlen
▲ Show 20 Lines • Show All 179 Lines • Show Last 20 Lines

libc/spec/gnu_ext.td

Show First 20 Lines • Show All 62 Lines • ▼ Show 20 Lines HeaderSpec String = HeaderSpec<
RetValSpec<VoidPtr>, RetValSpec<VoidPtr>,
[ArgSpec<VoidPtr>, ArgSpec<IntType>, ArgSpec<SizeTType>] [ArgSpec<VoidPtr>, ArgSpec<IntType>, ArgSpec<SizeTType>]
>, >,
FunctionSpec< FunctionSpec<
"strerror_r", "strerror_r",
RetValSpec<CharPtr>, RetValSpec<CharPtr>,
[ArgSpec<IntType>, ArgSpec<CharPtr>, ArgSpec<SizeTType>] [ArgSpec<IntType>, ArgSpec<CharPtr>, ArgSpec<SizeTType>]
>, >,
FunctionSpec<
"strcasestr",
RetValSpec<CharPtr>,
[ArgSpec<ConstCharPtr>, ArgSpec<ConstCharPtr>]
>,
] ]
>; >;
HeaderSpec FEnv = HeaderSpec< HeaderSpec FEnv = HeaderSpec<
"fenv.h", "fenv.h",
[], // Macros [], // Macros
[], // Types [], // Types
[], // Enumerations [], // Enumerations
▲ Show 20 Lines • Show All 137 Lines • Show Last 20 Lines

libc/src/string/CMakeLists.txt

Show First 20 Lines • Show All 122 Lines • ▼ Show 20 Linesadd_entrypoint_object(
HDRS HDRS
strcasecmp.h strcasecmp.h
DEPENDS DEPENDS
.memory_utils.strcmp_implementation .memory_utils.strcmp_implementation
libc.src.__support.ctype_utils libc.src.__support.ctype_utils
) )
add_entrypoint_object( add_entrypoint_object(
strcasestr
SRCS
strcasestr.cpp
HDRS
strcasestr.h
DEPENDS
.memory_utils.strstr_implementation
libc.src.__support.ctype_utils
)
add_entrypoint_object(
strcoll strcoll
SRCS SRCS
strcoll.cpp strcoll.cpp
HDRS HDRS
strcoll.h strcoll.h
) )
add_entrypoint_object( add_entrypoint_object(
▲ Show 20 Lines • Show All 429 Lines • Show Last 20 Lines

libc/src/string/strcasestr.h

  • This file was added.
//===-- Implementation header for strcasestr --------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef LLVM_LIBC_SRC_STRING_STRCASECMP_H
#define LLVM_LIBC_SRC_STRING_STRCASECMP_H
namespace __llvm_libc {
char *strcasestr(const char *needle, const char *haystack);
} // namespace __llvm_libc
#endif // LLVM_LIBC_SRC_STRING_STRCASECMP_H

libc/src/string/strcasestr.cpp

  • This file was added.
//===-- Implementation of strcasestr --------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "src/string/strcasestr.h"
#include "src/__support/common.h"
#include "src/__support/ctype_utils.h"
#include "src/string/memory_utils/strstr_implementations.h"
namespace __llvm_libc {
// TODO: This is a simple brute force implementation. This can be
// improved upon using well known string matching algorithms.
LLVM_LIBC_FUNCTION(char *, strcasestr,
(const char *haystack, const char *needle)) {
auto case_cmp = [](char a, char b) {
return __llvm_libc::internal::tolower(a) -
__llvm_libc::internal::tolower(b);
};
return strstr_implementation(haystack, needle, case_cmp);
}
} // namespace __llvm_libc

libc/test/src/string/CMakeLists.txt

Show First 20 Lines • Show All 109 Lines • ▼ Show 20 Lines SUITE
libc_string_unittests libc_string_unittests
SRCS SRCS
strcasecmp_test.cpp strcasecmp_test.cpp
DEPENDS DEPENDS
libc.src.string.strcasecmp libc.src.string.strcasecmp
) )
add_libc_unittest( add_libc_unittest(
strcasestr_test
SUITE
libc_string_unittests
SRCS
strcasestr_test.cpp
DEPENDS
libc.src.string.strcasestr
)
add_libc_unittest(
strcoll_test strcoll_test
SUITE SUITE
libc_string_unittests libc_string_unittests
SRCS SRCS
strcoll_test.cpp strcoll_test.cpp
DEPENDS DEPENDS
libc.src.string.strcoll libc.src.string.strcoll
) )
▲ Show 20 Lines • Show All 248 Lines • Show Last 20 Lines

libc/test/src/string/strcasestr_test.cpp

  • This file was added.
//===-- Unittests for strcasestr ------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "src/string/strcasestr.h"
#include "utils/UnitTest/Test.h"
TEST(LlvmLibcStrCaseStrTest, NeedleNotInHaystack) {
EXPECT_STREQ(__llvm_libc::strcasestr("abcd", "e"), nullptr);
EXPECT_STREQ(__llvm_libc::strcasestr("ABCD", "e"), nullptr);
EXPECT_STREQ(__llvm_libc::strcasestr("abcd", "E"), nullptr);
EXPECT_STREQ(__llvm_libc::strcasestr("ABCD", "E"), nullptr);
}
TEST(LlvmLibcStrCaseStrTest, NeedleInMiddle) {
EXPECT_STREQ(__llvm_libc::strcasestr("abcdefghi", "def"), "defghi");
EXPECT_STREQ(__llvm_libc::strcasestr("ABCDEFGHI", "def"), "DEFGHI");
EXPECT_STREQ(__llvm_libc::strcasestr("abcdefghi", "DEF"), "defghi");
EXPECT_STREQ(__llvm_libc::strcasestr("ABCDEFGHI", "DEF"), "DEFGHI");
}