[BOLT] Emit a warning about invalid entries in function-order list

[Amir]

Summary

Move individual warnings under verbosity >= 1, print out a warning with
aggregate number.

[rafauler]

I guess the changes in RewriteInstance.cpp are not part of this diff, since they don't match the commit message?

[maksfb]

bolt/lib/Passes/ReorderFunctions.cpp

386–387

nit: keep naming ("Reorder functions" vs "ReorderFunctions") consistent (you can also use this->getName()). Drop the trailing period.

[Amir]

In D142397#4075044, @rafauler wrote:

I guess the changes in RewriteInstance.cpp are not part of this diff, since they don't match the commit message?

Right, these changes belong to D142269

[Amir]

Update warning messages, remove unrelated changes

[rafauler]

LGTM

bolt/lib/Passes/ReorderFunctions.cpp

case RT_PETTIS_HANSEN:
     break;
   case RT_RANDOM:
     std::srand(opts::RandomSeed);
     Clusters = randomClusters(Cg);
     break;
   case RT_USER:
     {
       uint32_t Index = 0;
+      uint32_t InvalidEntries = 0;
       for (const std::string &Function : readFunctionOrderFile()) {
         std::vector<uint64_t> FuncAddrs;
 
         BinaryData *BD = BC.getBinaryDataByName(Function);
         if (!BD) {
           uint32_t LocalID = 1;
           while (true) {
             // If we can't find the main symbol name, look for alternates.
             const std::string FuncName =
                 Function + "/" + std::to_string(LocalID);
             BD = BC.getBinaryDataByName(FuncName);
             if (BD)
               FuncAddrs.push_back(BD->getAddress());
             else
               break;
             LocalID++;
           }
         } else {
           FuncAddrs.push_back(BD->getAddress());
         }
 
         if (FuncAddrs.empty()) {
-          errs() << "BOLT-WARNING: Reorder functions: can't find function for "
-                 << Function << ".\n";
+          if (opts::Verbosity >= 1)
+            errs() << "BOLT-WARNING: Reorder functions: can't find function "
+                   << "for " << Function << "\n";
+          ++InvalidEntries;
           continue;
         }
 
         for (const uint64_t FuncAddr : FuncAddrs) {
           const BinaryData *FuncBD = BC.getBinaryDataAtAddress(FuncAddr);
           assert(FuncBD);
 
           BinaryFunction *BF = BC.getFunctionForSymbol(FuncBD->getSymbol());
           if (!BF) {
-            errs() << "BOLT-WARNING: Reorder functions: can't find function for "
-                   << Function << ".\n";
+            if (opts::Verbosity >= 1)
+              errs() << "BOLT-WARNING: Reorder functions: can't find function "
+                     << "for " << Function << "\n";
+            ++InvalidEntries;
             break;
           }
           if (!BF->hasValidIndex())
             BF->setIndex(Index++);
           else if (opts::Verbosity > 0)
             errs() << "BOLT-WARNING: Duplicate reorder entry for " << Function
-                   << ".\n";
+                   << "\n";
         }
       }
+      if (InvalidEntries)
+        errs() << "BOLT-WARNING: Reorder functions: can't find functions for "
+               << InvalidEntries << " entries in -function-order list\n";
     }
     break;
   }
 
   reorder(std::move(Clusters), BFs);
 
   std::unique_ptr<std::ofstream> FuncsFile;
   if (!opts::GenerateFunctionOrderFile.empty()) {