The HIP CMake files expect to find their own dependencies and don't
use or respect PATHS or HINTS, relying on CMAKE_PREFIX_PATH to contain
/opt/rocm and /opt/rocm/hip . This is not great for the rest of the
build. Therefore, copy the CMake prefix path, add the ROCm
directories, find HIP, and reset the path to its old value.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
It would be more productive to fix the rocm cmake huild if you’re going to touch this. Not respecting paths or hints is very broken
Comment Actions
@arsenm That being said, would this make the hack more acceptable since now loading in hip doesn't pollute the global CMake context?
(I don't even know how to start trying to change ROCm's cmake files)