This is an archive of the discontinued LLVM Phabricator instance.

Differential D142246

[HIP] Change default offload arch to gfx906
ClosedPublic

Authored by yaxunl on Jan 20 2023, 12:00 PM.

Details

Reviewers
tra
Commits
rGc487b84d7552: [HIP] Change default offload arch to gfx906
Summary

Change default offload arch to gfx906 since
it is the lowest officially supported offload
arch (https://docs.amd.com/bundle/ROCm-Release-Notes-v5.4/page/About_This_Document.html#d2e131).

Diff Detail

Unit TestsFailed

TimeTest
3,820 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/algorithms/specialized_algorithms/special_mem_concepts::nothrow_sentinel_for.compile.pass.cpp

Event Timeline

yaxunl created this revision.Jan 20 2023, 12:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 12:00 PM
yaxunl requested review of this revision.Jan 20 2023, 12:00 PM
Herald added a subscriber: MaskRay. · View Herald TranscriptJan 20 2023, 12:00 PM
tra accepted this revision.Jan 20 2023, 12:14 PM
This revision is now accepted and ready to land.Jan 20 2023, 12:14 PM
Harbormaster completed remote builds in B209051: Diff 490935.Jan 20 2023, 2:28 PM
This revision was landed with ongoing or failed builds.Jan 22 2023, 6:22 PM
Closed by commit rGc487b84d7552: [HIP] Change default offload arch to gfx906 (authored by yaxunl). · Explain Why
This revision was automatically updated to reflect the committed changes.
yaxunl added a commit: rGc487b84d7552: [HIP] Change default offload arch to gfx906.
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2023, 6:22 PM

Revision Contents

PathSize
clang/
lib/
Driver/
2 lines
test/
Driver/
2 lines

Diff 490935

clang/lib/Driver/Driver.cpp

Show First 20 Lines • Show All 3,297 Lines • ▼ Show 20 Lines class HIPActionBuilder final : public CudaActionBuilderBase {
// only compilation. Bundle other type of output files only if // only compilation. Bundle other type of output files only if
// --gpu-bundle-output is specified for device only compilation. // --gpu-bundle-output is specified for device only compilation.
std::optional<bool> BundleOutput; std::optional<bool> BundleOutput;
public: public:
HIPActionBuilder(Compilation &C, DerivedArgList &Args, HIPActionBuilder(Compilation &C, DerivedArgList &Args,
const Driver::InputList &Inputs) const Driver::InputList &Inputs)
: CudaActionBuilderBase(C, Args, Inputs, Action::OFK_HIP) { : CudaActionBuilderBase(C, Args, Inputs, Action::OFK_HIP) {
DefaultCudaArch = CudaArch::GFX803; DefaultCudaArch = CudaArch::GFX906;
if (Args.hasArg(options::OPT_gpu_bundle_output, if (Args.hasArg(options::OPT_gpu_bundle_output,
options::OPT_no_gpu_bundle_output)) options::OPT_no_gpu_bundle_output))
BundleOutput = Args.hasFlag(options::OPT_gpu_bundle_output, BundleOutput = Args.hasFlag(options::OPT_gpu_bundle_output,
options::OPT_no_gpu_bundle_output, true); options::OPT_no_gpu_bundle_output, true);
} }
bool canUseBundlerUnbundler() const override { return true; } bool canUseBundlerUnbundler() const override { return true; }
▲ Show 20 Lines • Show All 3,075 Lines • Show Last 20 Lines

clang/test/Driver/hip-default-gpu-arch.hip

// REQUIRES: x86-registered-target // REQUIRES: x86-registered-target
// REQUIRES: amdgpu-registered-target // REQUIRES: amdgpu-registered-target
// RUN: %clang -### -c %s 2>&1 | FileCheck %s // RUN: %clang -### -c %s 2>&1 | FileCheck %s
// CHECK: {{.*}}clang{{.*}}"-target-cpu" "gfx803" // CHECK: {{.*}}clang{{.*}}"-target-cpu" "gfx906"