This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Disable tests that are incompatible with Windows
ClosedPublic

Authored by andrewng on Jan 20 2023, 8:49 AM.

Details

Summary

These tests explicitly make use of POSIX absolute paths.

Diff Detail

Event Timeline

andrewng created this revision.Jan 20 2023, 8:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 8:49 AM
Herald added a subscriber: arphaman. · View Herald Transcript
andrewng requested review of this revision.Jan 20 2023, 8:49 AM
nridge added a subscriber: nridge.Jan 21 2023, 6:24 PM

thanks this makes sense! we were filtering on target_triple before, which is not right, especially when host triple is not the default target.

as a follow up i'll drop all the target={{...}} conditions as we should actually be able to run these tests even when they're cross-compiling to windows, let's not do this as part of this patch though as it might trigger running on new buildbots and failures for unrelated reasons.

kadircet accepted this revision.Jan 27 2023, 6:43 AM
This revision is now accepted and ready to land.Jan 27 2023, 6:43 AM