Page MenuHomePhabricator

[OpenMP] Don't set rpath for system paths
AbandonedPublic

Authored by tstellar on Jan 19 2023, 8:31 PM.

Diff Detail

Unit TestsFailed

TimeTest
3,650 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/algorithms/specialized_algorithms/special_mem_concepts::nothrow_sentinel_for.compile.pass.cpp
Script: -- : 'COMPILED WITH'; /home/libcxx-builder/.buildkite-agent/builds/dd39b809c733-1/llvm-project/libcxx-ci/install/bin/clang++ /home/libcxx-builder/.buildkite-agent/builds/dd39b809c733-1/llvm-project/libcxx-ci/libcxx/test/libcxx/algorithms/specialized.algorithms/special.mem.concepts/nothrow_sentinel_for.compile.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/dd39b809c733-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/dd39b809c733-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/dd39b809c733-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -fsyntax-only

Event Timeline

tstellar created this revision.Jan 19 2023, 8:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2023, 8:31 PM
tstellar requested review of this revision.Jan 19 2023, 8:31 PM
Herald added a project: Restricted Project. · View Herald Transcript
tstellar added inline comments.Jan 19 2023, 8:32 PM
clang/lib/Driver/ToolChains/CommonArgs.cpp
799

I wasn't sure exactly how to determine if something is a system path, so I'm open to other ideas here.

JonChesterfield accepted this revision.Mar 6 2023, 8:09 AM

I'm happy with this but agree that "what might be a system path?" is a tricky heuristic. What we want is to exclude the places that the application will search anyway, but that's OS dependent. I'm mostly worried about toolchains installed under /opt or under $HOME so this is good for me. It's also easy to pull later if we reconsider.

This revision is now accepted and ready to land.Mar 6 2023, 8:09 AM

I'm happy with this but agree that "what might be a system path?" is a tricky heuristic. What we want is to exclude the places that the application will search anyway, but that's OS dependent. I'm mostly worried about toolchains installed under /opt or under $HOME so this is good for me. It's also easy to pull later if we reconsider.

Thank you for being considerate the use case. But I don't think we should base the decision on whether /usr/lib or /usr/lib64 is used and make directories different. We should unconditionally disable rpath, regardless of the directory path.

tstellar abandoned this revision.Mar 9 2023, 9:44 PM

-fopenmp-add-rpath has been removed.