This is an archive of the discontinued LLVM Phabricator instance.

[CSSPGO] Turn on postlink sample counts overwrite.
Needs ReviewPublic

Authored by hoy on Jan 17 2023, 10:17 AM.

Details

Reviewers
wenlei
wlei
Summary

The CS preinliner computes sample counts for outlined functions globally, resulting in a more accurate function profile than the actual thinlto postlink sample inliner does. I've seen that turning on --overwrite-existing-weights for postlink results in general 0.5% to 1% code size win (perf wise is netural) for CSSPGO accross four of our big internal services, but slight code size regression for non-CS AutoFDO. I'm turning on the switch for preinlined profile only.

Diff Detail

Event Timeline

hoy created this revision.Jan 17 2023, 10:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2023, 10:17 AM
hoy requested review of this revision.Jan 17 2023, 10:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2023, 10:17 AM