This is an archive of the discontinued LLVM Phabricator instance.

Differential D141707

[CodeGen] Fix build failure due to missing declaration.
ClosedPublic

Authored by fpetrogalli on Jan 13 2023, 10:27 AM.

Details

Reviewers
fhahn
Commits
rGc3c6d47c45bc: [CodeGen] Fix build failure due to missing declaration.
Summary

The failure was reported in https://github.com/llvm/llvm-project/issues/60011

FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineScheduler.cpp.o
"/build/llvm-toolchain-snapshot-16~++20230113111109+aba8983c9d86/build-llvm/./bin/clang++" -D_GNU_SOURCE -DSTDC_CONSTANT_MACROS -DSTDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I"/build/llvm-toolchain-snapshot-16~++20230113111109+aba8983c9d86/build-llvm/tools/clang/stage2-bins/lib/CodeGen" -I"/build/llvm-toolchain-snapshot-16~++20230113111109+aba8983c9d86/llvm/lib/CodeGen" -I"/build/llvm-toolchain-snapshot-16~++20230113111109+aba8983c9d86/build-llvm/tools/clang/stage2-bins/include" -I"/build/llvm-toolchain-snapshot-16~++20230113111109+aba8983c9d86/llvm/include" -fstack-protector-strong -Wformat -Werror=format-security -Wno-unused-command-line-argument -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -ffile-prefix-map=/build/llvm-toolchain-snapshot-16~++20230113111109+aba8983c9d86/build-llvm/tools/clang/stage2-bins=build-llvm/tools/clang/stage2-bins -ffile-prefix-map=/build/llvm-toolchain-snapshot-16~++20230113111109+aba8983c9d86/= -no-canonical-prefixes -O2 -DNDEBUG -g1 -fno-exceptions -std=c++17 -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineScheduler.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineScheduler.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineScheduler.cpp.o -c '/build/llvm-toolchain-snapshot-16~++20230113111109+aba8983c9d86/llvm/lib/CodeGen/MachineScheduler.cpp'
/build/llvm-toolchain-snapshot-16~++20230113111109+aba8983c9d86/llvm/lib/CodeGen/MachineScheduler.cpp:2639:7: error: use of undeclared identifier 'MISchedDumpReservedCycles'

if (MISchedDumpReservedCycles)
    ^

1 error generated.

Diff Detail

Event Timeline

fpetrogalli created this revision.Jan 13 2023, 10:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2023, 10:27 AM
Herald added subscribers: ecnelises, javed.absar, hiraditya, MatzeB. · View Herald Transcript
fpetrogalli requested review of this revision.Jan 13 2023, 10:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2023, 10:27 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
fhahn accepted this revision.Jan 13 2023, 10:34 AM
fhahn added a subscriber: fhahn.

LGTM, please add

Fixes #60011 to the commit message, so GitHub will auto-close the issue.

This revision is now accepted and ready to land.Jan 13 2023, 10:34 AM
Herald added a subscriber: StephenFan. · View Herald TranscriptJan 13 2023, 10:34 AM
This revision was landed with ongoing or failed builds.Jan 13 2023, 10:45 AM
Closed by commit rGc3c6d47c45bc: [CodeGen] Fix build failure due to missing declaration. (authored by fpetrogalli). · Explain Why
This revision was automatically updated to reflect the committed changes.
fpetrogalli added a commit: rGc3c6d47c45bc: [CodeGen] Fix build failure due to missing declaration..
Harbormaster completed remote builds in B207679: Diff 489059.Jan 13 2023, 12:32 PM
chapuni added a subscriber: chapuni.Jan 13 2023, 3:29 PM

I wonder it would cause a warning if NDEBUG but !LLVM_ENABLE_DUMP?

chapuni mentioned this in rG292019e931a0: MachineScheduler.cpp: Fixup D141707, suppress `MISchedDumpReservedCycles`….Jan 13 2023, 5:05 PM

Revision Contents

PathSize
llvm/
lib/
CodeGen/
1 line

Diff 489067

llvm/lib/CodeGen/MachineScheduler.cpp

Show First 20 Lines • Show All 95 Lines • ▼ Show 20 Lines
cl::opt<bool> PrintDAGs("misched-print-dags", cl::Hidden, cl::opt<bool> PrintDAGs("misched-print-dags", cl::Hidden,
cl::desc("Print schedule DAGs")); cl::desc("Print schedule DAGs"));
cl::opt<bool> MISchedDumpReservedCycles( cl::opt<bool> MISchedDumpReservedCycles(
"misched-dump-reserved-cycles", cl::Hidden, cl::init(false), "misched-dump-reserved-cycles", cl::Hidden, cl::init(false),
cl::desc("Dump resource usage at schedule boundary.")); cl::desc("Dump resource usage at schedule boundary."));
#else #else
const bool ViewMISchedDAGs = false; const bool ViewMISchedDAGs = false;
const bool PrintDAGs = false; const bool PrintDAGs = false;
const bool MISchedDumpReservedCycles = false;
#endif // NDEBUG #endif // NDEBUG
} // end namespace llvm } // end namespace llvm
#ifndef NDEBUG #ifndef NDEBUG
/// In some situations a few uninteresting nodes depend on nearly all other /// In some situations a few uninteresting nodes depend on nearly all other
/// nodes in the graph, provide a cutoff to hide them. /// nodes in the graph, provide a cutoff to hide them.
static cl::opt<unsigned> ViewMISchedCutoff("view-misched-cutoff", cl::Hidden, static cl::opt<unsigned> ViewMISchedCutoff("view-misched-cutoff", cl::Hidden,
▲ Show 20 Lines • Show All 3,866 Lines • Show Last 20 Lines