This is an archive of the discontinued LLVM Phabricator instance.

[mlir][EmitC] Remove Pure trait from `emitc.include`
ClosedPublic

Authored by christopherbate on Jan 13 2023, 10:04 AM.

Details

Summary

The op emitc.include does not have results and thus will be elided
during canonicalization, which is not correct behavior. This change
removes the 'Pure' trait and adds a canonicalization test.

Diff Detail

Event Timeline

christopherbate requested review of this revision.Jan 13 2023, 10:04 AM

Fix commit message.

christopherbate retitled this revision from [EmitC] Remove Pure trait from `emitc.include` to [mlir][EmitC] Remove Pure trait from `emitc.include`.Jan 13 2023, 10:05 AM
jpienaar accepted this revision.Jan 15 2023, 8:53 AM
jpienaar added a reviewer: marbre.
jpienaar added a subscriber: jpienaar.

LG, adding Marius for visibility.

This revision is now accepted and ready to land.Jan 15 2023, 8:53 AM
marbre accepted this revision.Jan 16 2023, 9:15 AM

Thanks for adding me @jpienaar and thanks @christopherbate for improving the EmitC dialect! LGTM.