- Implement https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2474r2.html
- Implement LWG3875(https://cplusplus.github.io/LWG/issue3875).
Depends on D151629
Differential D141699
[libc++][ranges] Implement P2474R2(`views::repeat`). yronglin on Jan 13 2023, 8:28 AM. Authored by
Details
Depends on D151629
Diff Detail
Event TimelineThere are a very large number of changes, so older changes are hidden. Show Older Changes
Comment Actions Sorry for the late reply and thanks a lot for your review! @var-const
Comment Actions Thanks for your review @var-const !
Comment Actions LGTM with the remaining comments addressed (and a green CI). Feel free to ping me directly if you have any questions re. my comments. Thanks!
Comment Actions I'm trusting @var-const here. I don't really have the time to do another deep dive here. Comment Actions Thanks for your review! @var-const @philnik
Comment Actions I mainly skimmed over it. I trust @philnik and @var-const to have done a deeper review; they are more familiar with the ranges details. Comment Actions Rather than explicitly enabling debug mode (which will fail in the hardened mode test), please add // UNSUPPORTED: !libcpp-has-hardened-mode && !libcpp-has-debug-mode |
Shouldn't this be annotated with the corresponding date rather than being marked *unimplemented*?