This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] SortUsingDeclarations support lexicographic order
ClosedPublic

Authored by Backl1ght on Jan 13 2023, 7:38 AM.

Diff Detail

Event Timeline

Backl1ght created this revision.Jan 13 2023, 7:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2023, 7:38 AM
Backl1ght requested review of this revision.Jan 13 2023, 7:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2023, 7:38 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Looks ok for me.

clang/include/clang/Format/Format.h
3517

You should use the same example lines as for the other options.

clang/lib/Format/UsingDeclarationsSorter.cpp
154–159

Use capital letters for variables and arguments.

Backl1ght updated this revision to Diff 489193.Jan 13 2023, 8:45 PM
  1. Update example for SUD_Never
  2. Use capital letters for variables and arguments.
Backl1ght marked 2 inline comments as done.Jan 13 2023, 11:51 PM
This revision is now accepted and ready to land.Jan 20 2023, 2:27 AM
This revision was landed with ongoing or failed builds.Jan 20 2023, 5:46 AM
This revision was automatically updated to reflect the committed changes.