Page MenuHomePhabricator
Differential D141694

[clang-format] SortUsingDeclarations support lexicographic order
ClosedPublic
Actions

Authored by Backl1ght on Jan 13 2023, 7:38 AM.

Details

Reviewers
MyDeveloperDay
rymiel
owenpan
HazardyKnusperkeks
Commits
rG58751f943f2f: [clang-format] SortUsingDeclarations support lexicographic order
Summary

fix https://github.com/llvm/llvm-project/issues/59930

Diff Detail

Event Timeline

Backl1ght created this revision.Jan 13 2023, 7:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2023, 7:38 AM
Backl1ght requested review of this revision.Jan 13 2023, 7:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2023, 7:38 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B207644: Diff 489003.Jan 13 2023, 8:45 AM
HazardyKnusperkeks added reviewers: owenpan, HazardyKnusperkeks.Jan 13 2023, 12:14 PM
HazardyKnusperkeks added a subscriber: HazardyKnusperkeks.

Looks ok for me.

clang/include/clang/Format/Format.h
3517

You should use the same example lines as for the other options.

clang/lib/Format/UsingDeclarationsSorter.cpp
154–159

Use capital letters for variables and arguments.

Backl1ght updated this revision to Diff 489193.Jan 13 2023, 8:45 PM
  1. Update example for SUD_Never
  2. Use capital letters for variables and arguments.
Harbormaster completed remote builds in B207775: Diff 489193.Jan 13 2023, 9:26 PM
Backl1ght marked 2 inline comments as done.Jan 13 2023, 11:51 PM
Backl1ght added a comment.Jan 17 2023, 4:20 AM

ping

HazardyKnusperkeks accepted this revision.Jan 20 2023, 2:27 AM
This revision is now accepted and ready to land.Jan 20 2023, 2:27 AM
This revision was landed with ongoing or failed builds.Jan 20 2023, 5:46 AM
Closed by commit rG58751f943f2f: [clang-format] SortUsingDeclarations support lexicographic order (authored by Backl1ght). · Explain Why
This revision was automatically updated to reflect the committed changes.
Backl1ght added a commit: rG58751f943f2f: [clang-format] SortUsingDeclarations support lexicographic order.

Revision Contents
Changeset List

PathSize
clang/
docs/
58 lines
include/
clang/
Format/
57 lines
lib/
Format/
21 lines
57 lines
unittests/
Format/
14 lines
516 lines

Diff 490795

View Options

clang/docs/ClangFormatStyleOptions.rst

Loading...
View Options

clang/include/clang/Format/Format.h

Loading...
View Options

clang/lib/Format/Format.cpp

Loading...
View Options

clang/lib/Format/UsingDeclarationsSorter.cpp

Loading...
View Options

clang/unittests/Format/ConfigParseTest.cpp

Loading...
View Options

clang/unittests/Format/UsingDeclarationsSorterTest.cpp

Loading...