This is an archive of the discontinued LLVM Phabricator instance.

test-release.sh: Only build clang for stage1 and stage2
ClosedPublic

Authored by tstellar on Jan 11 2023, 3:54 PM.

Details

Summary

The stage1 and stage2 builds aren't packaged, so we only need to build
enough of the toolchain to build the next phase.

Diff Detail

Event Timeline

tstellar created this revision.Jan 11 2023, 3:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2023, 3:54 PM
tstellar requested review of this revision.Jan 11 2023, 3:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2023, 3:54 PM

I think we should include lld as well - now that LLD can produce production binaries on all platforms I think it makes sense to prefer that over system linker.

When we discussed this earlier I think we talked about only running the tests at the end the product. I still think it makes sense to not do the full testing in Phase 1/2, but other people can disagree with that if we think it will not catch issues.

I think we should include lld as well - now that LLD can produce production binaries on all platforms I think it makes sense to prefer that over system linker.

I think in addition to building lld, we would also have to add another cmake flag like -DLLVM_USE_LLD when configuring. That might be worthy a separate change, since it will change the final output (whereas this current change does not affect the final output at all).

When we discussed this earlier I think we talked about only running the tests at the end the product. I still think it makes sense to not do the full testing in Phase 1/2, but other people can disagree with that if we think it will not catch issues.

It doesn't look like the tests currently run for stage 1 and stage 2.

thieta accepted this revision.Jan 13 2023, 9:55 AM

Good plan. Let's merge this and we can do another with lld later.

This revision is now accepted and ready to land.Jan 13 2023, 9:55 AM
amyk accepted this revision.Jan 17 2023, 11:21 AM

I think this LGTM as well.

This revision was landed with ongoing or failed builds.Jan 24 2023, 6:11 PM
This revision was automatically updated to reflect the committed changes.