In API tests, replace use of the p alias with the expression command.
To avoid conflating tests of the alias with tests of the expression command,
this patch canonicalizes to the use expression.
Paths
| Differential D141539
[lldb][test] Replace use of p with expression (NFC) ClosedPublic Authored by kastiglione on Jan 11 2023, 12:13 PM.
Details
Summary In API tests, replace use of the p alias with the expression command. To avoid conflating tests of the alias with tests of the expression command,
Diff Detail
Event TimelineComment Actions I think it makes sense to have one test that tests the p command alias and its parameter handling and have all other tests be explicit about whether they test the expression evaluator or the command alias. As such, this is a good canonicalization.
This revision is now accepted and ready to land.Jan 11 2023, 2:22 PM Comment Actions I will add explicit tests for p.
Closed by commit rG407666422838: [lldb][test] Replace use of p with expression (NFC) (authored by kastiglione). · Explain WhyJan 25 2023, 11:04 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 488331 lldb/test/API/commands/expression/codegen-crash-typedefdecl-not-in_declcontext/main.cpp
lldb/test/API/commands/expression/persist_objc_pointeetype/TestPersistObjCPointeeType.py
lldb/test/API/commands/expression/rdar44436068/main.c
lldb/test/API/commands/register/register/aarch64_sve_registers/rw_access_static_config/TestSVERegisters.py
lldb/test/API/commands/target/dump-pcm-info/TestDumpPCMInfo.py
lldb/test/API/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py
lldb/test/API/functionalities/data-formatter/data-formatter-ptr-to-array/TestPtrToArrayFormatting.py
lldb/test/API/functionalities/data-formatter/data-formatter-smart-array/TestDataFormatterSmartArray.py
lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/list/TestDataFormatterGenericList.py
lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/multimap/TestDataFormatterGenericMultiMap.py
lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/multiset/TestDataFormatterGenericMultiSet.py
lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/set/TestDataFormatterGenericSet.py
lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/map/TestDataFormatterLibccMap.py
lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/vector/TestDataFormatterLibcxxVector.py
lldb/test/API/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py
lldb/test/API/functionalities/data-formatter/data-formatter-stl/libstdcpp/vector/TestDataFormatterStdVector.py
lldb/test/API/functionalities/inferior-assert/TestInferiorAssert.py
lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashing.py
lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py
lldb/test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py
lldb/test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py
lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py
lldb/test/API/functionalities/set-data/TestSetData.py
lldb/test/API/functionalities/ubsan/user-expression/TestUbsanUserExpression.py
lldb/test/API/lang/c/enum_types/TestEnumTypes.py
lldb/test/API/lang/c/strings/TestCStrings.py
lldb/test/API/lang/cpp/namespace/TestNamespace.py
lldb/test/API/lang/objc/foundation/TestObjCMethodsNSError.py
lldb/test/API/lang/objc/modules-auto-import/TestModulesAutoImport.py
lldb/test/API/lang/objc/modules/TestObjCModules.py
lldb/test/API/lang/objc/objc-struct-argument/TestObjCStructArgument.py
lldb/test/API/lang/objc/radar-9691614/TestObjCMethodReturningBOOL.py
lldb/test/API/linux/aarch64/non_address_bit_memory_access/TestAArch64LinuxNonAddressBitMemoryAccess.py
lldb/test/API/linux/builtin_trap/TestBuiltinTrap.py
lldb/test/API/lua_api/TestFileHandle.lua
lldb/test/API/macosx/early-process-launch/TestEarlyProcessLaunch.py
lldb/test/API/macosx/macCatalyst/TestMacCatalyst.py
lldb/test/API/macosx/macCatalystAppMacOSFramework/TestMacCatalystAppWithMacOSFramework.py
lldb/test/API/python_api/file_handle/TestFileHandle.py
|
@aprantl I don't see why these /d are not needed though.