This is an archive of the discontinued LLVM Phabricator instance.

[lldb][test] Replace use of p with expression in Shell tests (NFC)
ClosedPublic

Authored by kastiglione on Mar 16 2023, 8:56 AM.

Details

Summary

In Shell tests, replace use of the p alias with the expression command.

To avoid conflating tests of the alias with tests of the expression command,
this patch canonicalizes to the use expression.

See also D141539 which made the same change to API tests.

Diff Detail

Event Timeline

kastiglione created this revision.Mar 16 2023, 8:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2023, 8:56 AM
kastiglione requested review of this revision.Mar 16 2023, 8:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2023, 8:56 AM
JDevlieghere accepted this revision.Mar 16 2023, 10:26 AM

LGTM. I probably would've gone with expo but as expression is the canonical name of the command, this makes sense.

This revision is now accepted and ready to land.Mar 16 2023, 10:26 AM

I probably would've gone with expr

I had it as expr at first and changed it to expression, since that's what I had done in D141539. I'm down to change it to expr, I think it's probably fine too.