This is an archive of the discontinued LLVM Phabricator instance.

[DirectX backend] emit metadata for DXIL version
Needs ReviewPublic

Authored by python3kgae on Jan 10 2023, 11:15 AM.

Details

Summary

New named metadata created with name "dx.version".
The content is shader model major - 5 and shader model minor.
sm6.0 will get dxil version 1.0.
sm6.6 will get dxil version 6.6.

Diff Detail

Event Timeline

python3kgae created this revision.Jan 10 2023, 11:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 10 2023, 11:15 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
python3kgae requested review of this revision.Jan 10 2023, 11:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 10 2023, 11:16 AM

Fix clang-format missed by arc lint.

Squash 2 commits.

beanz added inline comments.Jan 13 2023, 8:05 AM
llvm/lib/Target/DirectX/DXILMetadata.h
35

Since these are unrelated metadata entries, it makes more sense to do them in separate methods.