This is an archive of the discontinued LLVM Phabricator instance.

[libc++][format] Adds container adaptor formatters.
ClosedPublic

Authored by Mordante on Jan 9 2023, 8:14 AM.

Details

Reviewers
ldionne
vitaut
Group Reviewers
Restricted Project
Commits
rG04d4f4b3d4e4: [libc++][format] Adds container adaptor formatters.
Summary

Implements parts of

  • P2286R8 Formatting Ranges

Depends on D140653

Diff Detail

Event Timeline

Mordante created this revision.Jan 9 2023, 8:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2023, 8:14 AM
Mordante retitled this revision from [libc++][format] Ads container adaptor formatters. to [libc++][format] Adds container adaptor formatters..Jan 9 2023, 9:06 AM
Mordante updated this revision to Diff 487483.Jan 9 2023, 9:38 AM

CI fixes.

Mordante updated this revision to Diff 488303.Jan 11 2023, 11:18 AM

Rebased and adjusted to underlying changes.

Mordante published this revision for review.Jan 14 2023, 5:03 AM
Mordante added reviewers: ldionne, vitaut.
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2023, 5:03 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jan 17 2023, 9:20 AM
ldionne added inline comments.
libcxx/include/__format/container_adaptor.h
30–34

FWIW this rationale makes sense to me.

This revision is now accepted and ready to land.Jan 17 2023, 9:20 AM
Mordante marked an inline comment as done.Jan 18 2023, 9:58 AM

Thanks for the review!

This revision was automatically updated to reflect the committed changes.