This is an archive of the discontinued LLVM Phabricator instance.

[libc++][format] range-default-formatter for map
ClosedPublic

Authored by Mordante on Dec 31 2022, 4:30 AM.

Details

Reviewers
ldionne
vitaut
Group Reviewers
Restricted Project
Commits
rGaf5fc4b4d827: [libc++][format] range-default-formatter for map
Summary

Implements the range-default-formatter specialization range_format::map.

Implements parts of

  • P2286R8 Formatting Ranges
  • P2585R0 Improving default container formatting

Depends on D140653

Diff Detail

Event Timeline

Mordante created this revision.Dec 31 2022, 4:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 31 2022, 4:30 AM
Mordante updated this revision to Diff 485766.Dec 31 2022, 5:15 AM

CI fixes.

Mordante updated this revision to Diff 485805.Jan 1 2023, 8:03 AM

Polishing

Mordante published this revision for review.Jan 7 2023, 3:58 AM
Mordante added reviewers: ldionne, vitaut.
Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2023, 3:58 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jan 17 2023, 9:11 AM
ldionne added inline comments.
libcxx/test/std/utilities/format/format.range/format.range.fmtmap/format.functions.format.pass.cpp
2

Can we add tests with simple custom associative containers for sets and maps? You can e.g. wrap std::map with a custom type and only provide the right typedefs + basic functions to see if everything works.

This revision is now accepted and ready to land.Jan 17 2023, 9:11 AM
Mordante updated this revision to Diff 490549.Jan 19 2023, 9:03 AM

Rebased and addresses review comments.

Mordante updated this revision to Diff 490572.Jan 19 2023, 10:00 AM

Disables more tests for GCC-12.

This revision was landed with ongoing or failed builds.Jan 19 2023, 11:56 AM
This revision was automatically updated to reflect the committed changes.