This is an archive of the discontinued LLVM Phabricator instance.

[libc++][format] range-default-formatter for set.
ClosedPublic

Authored by Mordante on Jan 7 2023, 4:13 AM.

Details

Reviewers
ldionne
vitaut
Group Reviewers
Restricted Project
Commits
rG857cbb9276e5: [libc++][format] range-default-formatter for set.
Summary

Implements the range-default-formatter specialization range_format::set.

Implements parts of

  • P2286R8 Formatting Ranges
  • P2585R0 Improving default container formatting

Depends on D140801

Diff Detail

Event Timeline

Mordante created this revision.Jan 7 2023, 4:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2023, 4:13 AM
Mordante updated this revision to Diff 487155.Jan 8 2023, 3:40 AM

Polishing and CI fixes.

Mordante published this revision for review.Jan 8 2023, 5:07 AM
Mordante added reviewers: ldionne, vitaut.
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2023, 5:07 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jan 17 2023, 9:14 AM
ldionne added inline comments.
libcxx/test/std/utilities/format/format.range/format.range.fmtset/format.functions.tests.h
2

Same comment as for map, please make sure you have tests with a user-defined set like type.

This revision is now accepted and ready to land.Jan 17 2023, 9:14 AM
Mordante marked an inline comment as done.Jan 19 2023, 12:00 PM
Mordante updated this revision to Diff 490625.Jan 19 2023, 12:10 PM

Rebased and addresses review comments.

This revision was landed with ongoing or failed builds.Jan 20 2023, 8:40 AM
This revision was automatically updated to reflect the committed changes.