[Clang] [Python] Fix tests when default config file contains -include

[thesamesam]

Summary

In Gentoo, we make use of Clang's recently-enhanced config file support
and add a default include to clang invocations using '-include ...'.

This breaks clang-python tests like so:

======================================================================
ERROR: test_includes (tests.cindex.test_translation_unit.TestTranslationUnit)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/clang-python-15.0.6/work/clang/bindings/python/tests/cindex/test_translation_unit.py", line 145, in test_includes
    eq(i[0], i[1])
  File "/var/tmp/portage/dev-python/clang-python-15.0.6/work/clang/bindings/python/tests/cindex/test_translation_unit.py", line 132, in eq
    self.assert_normpaths_equal(expected[0], actual.source.name)
AttributeError: 'NoneType' object has no attribute 'name'

======================================================================
FAIL: test_inclusion_directive (tests.cindex.test_translation_unit.TestTranslationUnit)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/clang-python-15.0.6/work/clang/bindings/python/tests/cindex/test_translation_unit.py", line 157, in test_inclusion_directive
    self.assert_normpaths_equal(i[0], i[1])
  File "/var/tmp/portage/dev-python/clang-python-15.0.6/work/clang/bindings/python/tests/cindex/test_translation_unit.py", line 126, in assert_normpaths_equal
    self.assertEqual(os.path.normpath(path1),
AssertionError: '/var/tmp/portage/dev-python/clang-python-1[58 chars]r1.h' != '/usr/include/gentoo/fortify.h'
- /var/tmp/portage/dev-python/clang-python-15.0.6/work/clang/bindings/python/tests/cindex/INPUTS/header1.h
+ /usr/include/gentoo/fortify.h

Disable using the default Clang configuration files on the system, like
we did for other tests.

Bug: https://bugs.gentoo.org/890204
Signed-off-by: Sam James <[e-mail]>

[mgorny]

I'm wondering if we shouldn't just by setting CLANG_NO_DEFAULT_CONFIG=1 like in clang's test suite rather than tying to predict how different config files will affect these tests.

[thesamesam]

Set CLANG_NO_DEFAULT_CONFIG in environment instead to reduce
cat-and-mouse issues.

[thesamesam]

Add comment.

[xen0n]

clang/bindings/python/tests/cindex/util.py

82 ↗

(On Diff #487296)

This is essentially an import-time side effect, IMO it could be better to instead put the envvar provision in clang/bindings/python/tests/CMakeLists.txt: the add_custom_target there already is making use of env so should be relatively easy to stuff this there too.

[thesamesam]

clang/bindings/python/tests/cindex/util.py

82 ↗

(On Diff #487296)

I hesitated to do that because it doesn't vary with the environment at all (the test should never really be run with custom configs), but given you've suggested it, that tips the balance on me being undecided - so I'll implement that now. Thanks!

[thesamesam]

Switch to setting CLANG_NO_DEFAULT_CONFIG via CMake instead.

clang/bindings/python/tests/cindex/test_translation_unit.py

def test_includes(self):
                 self.assert_normpaths_equal(expected[1], actual.include.name)
 
         src = os.path.join(kInputsDir, 'include.cpp')
         h1 = os.path.join(kInputsDir, "header1.h")
         h2 = os.path.join(kInputsDir, "header2.h")
         h3 = os.path.join(kInputsDir, "header3.h")
         inc = [(src, h1), (h1, h3), (src, h2), (h2, h3)]
 
-        tu = TranslationUnit.from_source(src)
+        tu = TranslationUnit.from_source(src, ["--no-default-config"])
         for i in zip(inc, tu.get_includes()):
             eq(i[0], i[1])
 
     def test_inclusion_directive(self):
         src = os.path.join(kInputsDir, 'include.cpp')
         h1 = os.path.join(kInputsDir, "header1.h")
         h2 = os.path.join(kInputsDir, "header2.h")
         h3 = os.path.join(kInputsDir, "header3.h")
         inc = [h1, h3, h2, h3, h1]
 
-        tu = TranslationUnit.from_source(src, options=TranslationUnit.PARSE_DETAILED_PROCESSING_RECORD)
+        tu = TranslationUnit.from_source(src, ["--no-default-config"], options=TranslationUnit.PARSE_DETAILED_PROCESSING_RECORD)
         inclusion_directive_files = [c.get_included_file().name for c in tu.cursor.get_children() if c.kind == CursorKind.INCLUSION_DIRECTIVE]
         for i in zip(inc, inclusion_directive_files):
             self.assert_normpaths_equal(i[0], i[1])
 
     def test_save(self):
         """Ensure TranslationUnit.save() works."""
 
         tu = get_tu('int foo();')