This is an archive of the discontinued LLVM Phabricator instance.

Differential D141228

[libc++] Granularize <bit> includes
ClosedPublic

Authored by philnik on Jan 8 2023, 9:58 AM.

Details

Reviewers
ldionne
Mordante
var-const
huixie90
Group Reviewers
Restricted Project
Commits
rG40a20ae6ab80: [libc++] Granularize <bit> includes

Diff Detail

Unit TestsFailed

TimeTest
1,500,270 mslibcxx CI Apple back-deployment macosx10.9 > apple-libc++-backdeployment-cfg-in.std/thread/thread_condition::notify_all_at_thread_exit_lwg3343.pass.cpp
13,040 mslibcxx CI Clang-cl (DLL) > llvm-libc++-shared-clangcl-cfg-in.std/thread/thread_mutex/thread_lock/thread_lock_unique/thread_lock_unique_cons::mutex_duration.pass.cpp
12,880 mslibcxx CI Clang-cl (DLL) > llvm-libc++-shared-clangcl-cfg-in.std/thread/thread_mutex/thread_lock/thread_lock_unique/thread_lock_unique_cons::mutex_time_point.pass.cpp

Event Timeline

philnik created this revision.Jan 8 2023, 9:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2023, 9:58 AM
philnik requested review of this revision.Jan 8 2023, 9:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2023, 9:58 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B206373: Diff 487205.Jan 8 2023, 10:27 AM
philnik updated this revision to Diff 496930.Feb 13 2023, 4:27 AM

Rebased

Harbormaster completed remote builds in B213397: Diff 496930.Feb 13 2023, 6:49 AM
ldionne accepted this revision.Feb 16 2023, 9:26 AM
This revision is now accepted and ready to land.Feb 16 2023, 9:26 AM
This revision was landed with ongoing or failed builds.Feb 17 2023, 2:36 AM
Closed by commit rG40a20ae6ab80: [libc++] Granularize <bit> includes (authored by philnik). · Explain Why
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rG40a20ae6ab80: [libc++] Granularize <bit> includes.

Revision Contents

PathSize
libcxx/
include/
__format/
1 line
2 lines
__random/
2 lines
1 line
1 line
test/
libcxx/
transitive_includes/
2 lines
2 lines
2 lines
2 lines
1 line
4 lines
std/
numerics/
bit/
bit.endian/
2 lines

Diff 496930

libcxx/include/__format/parser_std_format_spec.h

Show All 25 Lines
#include <__format/format_arg.h> #include <__format/format_arg.h>
#include <__format/format_error.h> #include <__format/format_error.h>
#include <__format/format_parse_context.h> #include <__format/format_parse_context.h>
#include <__format/format_string.h> #include <__format/format_string.h>
#include <__format/unicode.h> #include <__format/unicode.h>
#include <__iterator/concepts.h> #include <__iterator/concepts.h>
#include <__iterator/readable_traits.h> // iter_value_t #include <__iterator/readable_traits.h> // iter_value_t
#include <__variant/monostate.h> #include <__variant/monostate.h>
#include <bit>
#include <cstdint> #include <cstdint>
#include <string_view> #include <string_view>
#include <type_traits> #include <type_traits>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
▲ Show 20 Lines • Show All 922 Lines • Show Last 20 Lines

libcxx/include/__format/unicode.h

// -*- C++ -*- // -*- C++ -*-
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef _LIBCPP___FORMAT_UNICODE_H #ifndef _LIBCPP___FORMAT_UNICODE_H
#define _LIBCPP___FORMAT_UNICODE_H #define _LIBCPP___FORMAT_UNICODE_H
#include <__assert> #include <__assert>
#include <__bit/countl.h>
#include <__concepts/same_as.h> #include <__concepts/same_as.h>
#include <__config> #include <__config>
#include <__format/extended_grapheme_cluster_table.h> #include <__format/extended_grapheme_cluster_table.h>
#include <__iterator/concepts.h> #include <__iterator/concepts.h>
#include <__iterator/readable_traits.h> // iter_value_t #include <__iterator/readable_traits.h> // iter_value_t
#include <__type_traits/make_unsigned.h> #include <__type_traits/make_unsigned.h>
#include <__utility/unreachable.h> #include <__utility/unreachable.h>
#include <bit>
#include <string_view> #include <string_view>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
▲ Show 20 Lines • Show All 474 Lines • Show Last 20 Lines

libcxx/include/__random/uniform_int_distribution.h

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef _LIBCPP___RANDOM_UNIFORM_INT_DISTRIBUTION_H #ifndef _LIBCPP___RANDOM_UNIFORM_INT_DISTRIBUTION_H
#define _LIBCPP___RANDOM_UNIFORM_INT_DISTRIBUTION_H #define _LIBCPP___RANDOM_UNIFORM_INT_DISTRIBUTION_H
#include <__bit/countl.h>
#include <__config> #include <__config>
#include <__random/is_valid.h> #include <__random/is_valid.h>
#include <__random/log2.h> #include <__random/log2.h>
#include <__type_traits/conditional.h> #include <__type_traits/conditional.h>
#include <__type_traits/make_unsigned.h> #include <__type_traits/make_unsigned.h>
#include <bit>
#include <cstddef> #include <cstddef>
#include <cstdint> #include <cstdint>
#include <iosfwd> #include <iosfwd>
#include <limits> #include <limits>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
▲ Show 20 Lines • Show All 268 Lines • Show Last 20 Lines

libcxx/include/algorithm

Show First 20 Lines • Show All 1,921 Lines • ▼ Show 20 Lines
#endif #endif
#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 17 #if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 17
# include <chrono> # include <chrono>
#endif #endif
#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20 #if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20
# include <atomic> # include <atomic>
# include <bit>
# include <concepts> # include <concepts>
# include <cstring> # include <cstring>
# include <iterator> # include <iterator>
# include <memory> # include <memory>
# include <stdexcept> # include <stdexcept>
# include <type_traits> # include <type_traits>
# include <utility> # include <utility>
#endif #endif
#endif // _LIBCPP_ALGORITHM #endif // _LIBCPP_ALGORITHM

libcxx/include/chrono

Show First 20 Lines • Show All 776 Lines • ▼ Show 20 Lines
#endif #endif
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20 #if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20
# include <bit>
# include <concepts> # include <concepts>
#endif #endif
#endif // _LIBCPP_CHRONO #endif // _LIBCPP_CHRONO

libcxx/test/libcxx/transitive_includes/cxx03.csv

Show First 20 Lines • Show All 99 Lines • ▼ Show 20 Lines
charconv cstddef charconv cstddef
charconv cstdint charconv cstdint
charconv cstdlib charconv cstdlib
charconv cstring charconv cstring
charconv initializer_list charconv initializer_list
charconv iosfwd charconv iosfwd
charconv limits charconv limits
charconv type_traits charconv type_traits
chrono bit
chrono compare chrono compare
chrono concepts chrono concepts
chrono cstddef chrono cstddef
chrono cstdint chrono cstdint
chrono cstdlib chrono cstdlib
chrono ctime chrono ctime
chrono limits chrono limits
chrono ratio chrono ratio
▲ Show 20 Lines • Show All 201 Lines • ▼ Show 20 Lines
filesystem new filesystem new
filesystem ratio filesystem ratio
filesystem string filesystem string
filesystem string_view filesystem string_view
filesystem system_error filesystem system_error
filesystem type_traits filesystem type_traits
filesystem version filesystem version
format array format array
format bit
format charconv format charconv
format cstddef format cstddef
format cstdint format cstdint
format cstdlib format cstdlib
format cstring format cstring
format initializer_list format initializer_list
format limits format limits
format locale format locale
▲ Show 20 Lines • Show All 606 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx11.csv

Show First 20 Lines • Show All 99 Lines • ▼ Show 20 Lines
charconv cstddef charconv cstddef
charconv cstdint charconv cstdint
charconv cstdlib charconv cstdlib
charconv cstring charconv cstring
charconv initializer_list charconv initializer_list
charconv iosfwd charconv iosfwd
charconv limits charconv limits
charconv type_traits charconv type_traits
chrono bit
chrono compare chrono compare
chrono concepts chrono concepts
chrono cstddef chrono cstddef
chrono cstdint chrono cstdint
chrono cstdlib chrono cstdlib
chrono ctime chrono ctime
chrono limits chrono limits
chrono ratio chrono ratio
▲ Show 20 Lines • Show All 201 Lines • ▼ Show 20 Lines
filesystem new filesystem new
filesystem ratio filesystem ratio
filesystem string filesystem string
filesystem string_view filesystem string_view
filesystem system_error filesystem system_error
filesystem type_traits filesystem type_traits
filesystem version filesystem version
format array format array
format bit
format charconv format charconv
format cstddef format cstddef
format cstdint format cstdint
format cstdlib format cstdlib
format cstring format cstring
format initializer_list format initializer_list
format limits format limits
format locale format locale
▲ Show 20 Lines • Show All 607 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx14.csv

Show First 20 Lines • Show All 99 Lines • ▼ Show 20 Lines
charconv cstddef charconv cstddef
charconv cstdint charconv cstdint
charconv cstdlib charconv cstdlib
charconv cstring charconv cstring
charconv initializer_list charconv initializer_list
charconv iosfwd charconv iosfwd
charconv limits charconv limits
charconv type_traits charconv type_traits
chrono bit
chrono compare chrono compare
chrono concepts chrono concepts
chrono cstddef chrono cstddef
chrono cstdint chrono cstdint
chrono cstdlib chrono cstdlib
chrono ctime chrono ctime
chrono limits chrono limits
chrono ratio chrono ratio
▲ Show 20 Lines • Show All 203 Lines • ▼ Show 20 Lines
filesystem new filesystem new
filesystem ratio filesystem ratio
filesystem string filesystem string
filesystem string_view filesystem string_view
filesystem system_error filesystem system_error
filesystem type_traits filesystem type_traits
filesystem version filesystem version
format array format array
format bit
format charconv format charconv
format cstddef format cstddef
format cstdint format cstdint
format cstdlib format cstdlib
format cstring format cstring
format initializer_list format initializer_list
format limits format limits
format locale format locale
▲ Show 20 Lines • Show All 614 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx17.csv

Show First 20 Lines • Show All 99 Lines • ▼ Show 20 Lines
charconv cstddef charconv cstddef
charconv cstdint charconv cstdint
charconv cstdlib charconv cstdlib
charconv cstring charconv cstring
charconv initializer_list charconv initializer_list
charconv iosfwd charconv iosfwd
charconv limits charconv limits
charconv type_traits charconv type_traits
chrono bit
chrono compare chrono compare
chrono concepts chrono concepts
chrono cstddef chrono cstddef
chrono cstdint chrono cstdint
chrono cstdlib chrono cstdlib
chrono ctime chrono ctime
chrono limits chrono limits
chrono ratio chrono ratio
▲ Show 20 Lines • Show All 203 Lines • ▼ Show 20 Lines
filesystem new filesystem new
filesystem ratio filesystem ratio
filesystem string filesystem string
filesystem string_view filesystem string_view
filesystem system_error filesystem system_error
filesystem type_traits filesystem type_traits
filesystem version filesystem version
format array format array
format bit
format charconv format charconv
format cstddef format cstddef
format cstdint format cstdint
format cstdlib format cstdlib
format cstring format cstring
format initializer_list format initializer_list
format limits format limits
format locale format locale
▲ Show 20 Lines • Show All 614 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx20.csv

Show First 20 Lines • Show All 327 Lines • ▼ Show 20 Lines
filesystem new filesystem new
filesystem ratio filesystem ratio
filesystem string filesystem string
filesystem string_view filesystem string_view
filesystem system_error filesystem system_error
filesystem type_traits filesystem type_traits
filesystem version filesystem version
format array format array
format bit
format charconv format charconv
format cstddef format cstddef
format cstdint format cstdint
format cstdlib format cstdlib
format cstring format cstring
format initializer_list format initializer_list
format limits format limits
format locale format locale
▲ Show 20 Lines • Show All 612 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx2b.csv

algorithm bit
algorithm climits algorithm climits
algorithm cstddef algorithm cstddef
algorithm cstdint algorithm cstdint
algorithm cstdlib algorithm cstdlib
algorithm cstring algorithm cstring
algorithm initializer_list algorithm initializer_list
algorithm iosfwd algorithm iosfwd
algorithm limits algorithm limits
▲ Show 20 Lines • Show All 58 Lines • ▼ Show 20 Lines
charconv cstddef charconv cstddef
charconv cstdint charconv cstdint
charconv cstdlib charconv cstdlib
charconv cstring charconv cstring
charconv initializer_list charconv initializer_list
charconv limits charconv limits
charconv type_traits charconv type_traits
chrono array chrono array
chrono bit
chrono charconv chrono charconv
chrono cmath chrono cmath
chrono compare chrono compare
chrono cstddef chrono cstddef
chrono cstdint chrono cstdint
chrono cstdlib chrono cstdlib
chrono cstring chrono cstring
chrono ctime chrono ctime
▲ Show 20 Lines • Show All 165 Lines • ▼ Show 20 Lines
filesystem new filesystem new
filesystem ratio filesystem ratio
filesystem string filesystem string
filesystem string_view filesystem string_view
filesystem system_error filesystem system_error
filesystem type_traits filesystem type_traits
filesystem version filesystem version
format array format array
format bit
format charconv format charconv
format cstddef format cstddef
format cstdint format cstdint
format cstdlib format cstdlib
format cstring format cstring
format initializer_list format initializer_list
format limits format limits
format locale format locale
▲ Show 20 Lines • Show All 212 Lines • ▼ Show 20 Lines
queue cstddef queue cstddef
queue cstdlib queue cstdlib
queue deque queue deque
queue initializer_list queue initializer_list
queue limits queue limits
queue type_traits queue type_traits
queue vector queue vector
queue version queue version
random bit
random cmath random cmath
random cstddef random cstddef
random cstdint random cstdint
random cstdlib random cstdlib
random initializer_list random initializer_list
random iosfwd random iosfwd
random limits random limits
random numeric random numeric
▲ Show 20 Lines • Show All 226 Lines • Show Last 20 Lines

libcxx/test/std/numerics/bit/bit.endian/endian.pass.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14, c++17 // UNSUPPORTED: c++03, c++11, c++14, c++17
// enum class endian; // enum class endian;
// <bit> // <bit>
#include <bit> #include <bit>
#include <cstring>
#include <cassert> #include <cassert>
#include <cstdint> #include <cstdint>
#include <cstring>
#include <type_traits> #include <type_traits>
#include "test_macros.h" #include "test_macros.h"
int main(int, char**) { int main(int, char**) {
static_assert(std::is_enum<std::endian>::value, ""); static_assert(std::is_enum<std::endian>::value, "");
// Check that E is a scoped enum by checking for conversions. // Check that E is a scoped enum by checking for conversions.
Show All 25 Lines