This is an archive of the discontinued LLVM Phabricator instance.

[ELF][test] Improve AVR relocation tests
ClosedPublic

Authored by benshi001 on Jan 7 2023, 6:48 AM.

Diff Detail

Event Timeline

benshi001 created this revision.Jan 7 2023, 6:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2023, 6:48 AM
benshi001 requested review of this revision.Jan 7 2023, 6:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2023, 6:48 AM
benshi001 added inline comments.Jan 7 2023, 6:49 AM
lld/test/ELF/avr-reloc.s
75

These checks are omitted due to avr disassembler bugs. Now the bugs are fixed and so these checks should be enabled.

aykevl accepted this revision.Jan 7 2023, 7:16 AM
This revision is now accepted and ready to land.Jan 7 2023, 7:16 AM

@MaskRay What's your opinion on the NFC ?

MaskRay accepted this revision.Jan 7 2023, 12:10 PM

Thanks!

MaskRay added a comment.EditedJan 7 2023, 12:10 PM

For pure test changes, I think [test] is more common than [NFC]

For lld/ELF lld/test/ELF, [ELF] is more common. There are many lld ports with very different code and [lld] in my view does not provide much value. Personally I only use [lld] for common lld code.

benshi001 retitled this revision from [lld][NFC] Improve AVR relocation tests to [ELF][test] Improve AVR relocation tests.Jan 7 2023, 5:34 PM

For pure test changes, I think [test] is more common than [NFC]

For lld/ELF lld/test/ELF, [ELF] is more common. There are many lld ports with very different code and [lld] in my view does not provide much value. Personally I only use [lld] for common lld code.

I will change to [ELF][test] while commtting. Thanks.

This revision was automatically updated to reflect the committed changes.