IROutliner: Fix another assert with non-0 alloca addrspaces

[arsenm]

Summary

Code is inserting an addrspacecast it shouldn't be, but
that's a separate CodeExtractor bug.

This also stops caring about typed pointers.

[arsenm]

Check function signature

[AndrewLitteken]

llvm/lib/Transforms/IPO/IROutliner.cpp

1335

What's the reasoning behind removing the check for the type of pointer and making it only care about whether it is a pointer? There can be multiple sets outputs to an set of extracted function and (as I understand it) the previous check looked checked that the argument type is a pointer to a specific type as well to not encounter errors later on.

[arsenm]

llvm/lib/Transforms/IPO/IROutliner.cpp

1335

Pointer element types are no more and it's not worth thinking about them

[arsenm]

ping, now there's really no reason to worry about typed pointers

[AndrewLitteken]

Makes sense, I don't think this will cause any issues then.

LGTM

[arsenm]

8c5a292202ff26ad51cf348001f82444d96e803b

llvm/lib/Transforms/IPO/IROutliner.cpp

for (Value *Output : Outputs) {
     unsigned ArgumentSize = Group.ArgumentTypes.size();
 
     // If the output is combined in a PHINode, we make sure to skip over it.
     if (OutputsReplacedByPHINode.contains(Output))
       continue;
 
     unsigned AggArgIdx = 0;
     for (unsigned Jdx = TypeIndex; Jdx < ArgumentSize; Jdx++) {
-      if (Group.ArgumentTypes[Jdx] != PointerType::getUnqual(Output->getType()))
+      if (!isa<PointerType>(Group.ArgumentTypes[Jdx]))
         continue;
 
       if (AggArgsUsed.contains(Jdx))
         continue;
 
       TypeFound = true;
       AggArgsUsed.insert(Jdx);
       Region.ExtractedArgToAgg.insert(std::make_pair(OriginalIndex, Jdx));

llvm/test/Transforms/IROutliner/alloca-addrspace-1.ll

+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --include-generated-funcs
+; RUN: opt -S -passes=iroutliner -ir-outlining-no-cost < %s | FileCheck %s
+
+target datalayout = "A5"
+
+define i32 @func_with_outgoing_new_allocas() {
+bb:
+  %i = tail call i32 @func0(i32 0, i32 1)
+  %i1 = or i32 0, %i
+  %i2 = tail call i32 @func0(i32 %i1, i32 0)
+  %i3 = or i32 %i1, %i2
+  %i4 = tail call i32 @llvm.foo(i32 %i3, i32 0)
+  ret i32 0
+}
+
+declare i32 @func0(i32, i32)
+declare i32 @llvm.foo(i32, i32)
+
+; CHECK-LABEL: define {{[^@]+}}@func_with_outgoing_new_allocas() {
+; CHECK-NEXT:  bb:
+; CHECK-NEXT:    [[I3_LOC:%.*]] = alloca i32, align 4, addrspace(5)
+; CHECK-NEXT:    [[I1_LOC:%.*]] = alloca i32, align 4, addrspace(5)
+; CHECK-NEXT:    [[LT_CAST:%.*]] = addrspacecast ptr addrspace(5) [[I1_LOC]] to ptr
+; CHECK-NEXT:    call void @llvm.lifetime.start.p0(i64 -1, ptr [[LT_CAST]])
+; CHECK-NEXT:    call void @outlined_ir_func_0(i32 0, i32 1, ptr addrspace(5) [[I1_LOC]])
+; CHECK-NEXT:    [[I1_RELOAD:%.*]] = load i32, ptr addrspace(5) [[I1_LOC]], align 4
+; CHECK-NEXT:    call void @llvm.lifetime.end.p0(i64 -1, ptr [[LT_CAST]])
+; CHECK-NEXT:    [[LT_CAST1:%.*]] = addrspacecast ptr addrspace(5) [[I3_LOC]] to ptr
+; CHECK-NEXT:    call void @llvm.lifetime.start.p0(i64 -1, ptr [[LT_CAST1]])
+; CHECK-NEXT:    call void @outlined_ir_func_0(i32 [[I1_RELOAD]], i32 0, ptr addrspace(5) [[I3_LOC]])
+; CHECK-NEXT:    [[I3_RELOAD:%.*]] = load i32, ptr addrspace(5) [[I3_LOC]], align 4
+; CHECK-NEXT:    call void @llvm.lifetime.end.p0(i64 -1, ptr [[LT_CAST1]])
+; CHECK-NEXT:    [[I4:%.*]] = tail call i32 @llvm.foo(i32 [[I3_RELOAD]], i32 0)
+; CHECK-NEXT:    ret i32 0
+;
+;
+; CHECK-LABEL: define {{[^@]+}}@outlined_ir_func_0
+; CHECK-SAME: (i32 [[TMP0:%.*]], i32 [[TMP1:%.*]], ptr addrspace(5) [[TMP2:%.*]]) #[[ATTR1:[0-9]+]] {
+; CHECK-NEXT:  newFuncRoot:
+; CHECK-NEXT:    br label [[BB_TO_OUTLINE:%.*]]
+; CHECK:       bb_to_outline:
+; CHECK-NEXT:    [[I:%.*]] = tail call i32 @func0(i32 [[TMP0]], i32 [[TMP1]])
+; CHECK-NEXT:    [[I1:%.*]] = or i32 [[TMP0]], [[I]]
+; CHECK-NEXT:    br label [[BB_AFTER_OUTLINE_EXITSTUB:%.*]]
+; CHECK:       bb_after_outline.exitStub:
+; CHECK-NEXT:    store i32 [[I1]], ptr addrspace(5) [[TMP2]], align 4
+; CHECK-NEXT:    ret void
+;