Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[NFC][LoopFlatten][LoopInterchange] Do not explicitly forget subloops
ClosedPublic
Actions

Authored by caojoshua on Jan 4 2023, 8:54 PM.

Details

Reviewers

congzhe
fhahn

Commits

rGb2b4d95827b7: [NFC][LoopFlatten][LoopInterchange] Do not explicitly forget subloops

Summary

We don't need to explicitly forget subloops because forgetting parent
loops will automatically forget their subloops

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	410 ms	x64 debian > Profile-x86_64.Linux::counter_promo_for.c
	380 ms	x64 debian > Profile-x86_64.Linux::counter_promo_while.c

Event Timeline

caojoshua created this revision.Jan 4 2023, 8:54 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 4 2023, 8:54 PM

Herald added a subscriber: hiraditya. · View Herald Transcript

caojoshua added reviewers: congzhe, SjoerdMeijer.Jan 4 2023, 9:01 PM

caojoshua edited reviewers, added: fhahn; removed: SjoerdMeijer.

caojoshua published this revision for review.Jan 4 2023, 9:03 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 4 2023, 9:03 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B205832: Diff 486464.Jan 4 2023, 9:46 PM

ping

Herald added a subscriber: StephenFan. · View Herald TranscriptJan 11 2023, 7:55 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jan 12 2023, 1:10 AM

This revision was landed with ongoing or failed builds.Jan 12 2023, 8:31 AM

Closed by commit rGb2b4d95827b7: [NFC][LoopFlatten][LoopInterchange] Do not explicitly forget subloops (authored by caojoshua). · Explain Why

This revision was automatically updated to reflect the committed changes.

caojoshua added a commit: rGb2b4d95827b7: [NFC][LoopFlatten][LoopInterchange] Do not explicitly forget subloops.

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Transforms/

Scalar/

LoopFlatten.cpp

3 lines

LoopInterchange.cpp

1 line

Diff 486464

View Options

llvm/lib/Transforms/Scalar/LoopFlatten.cpp