- User Since
- Jan 2 2020, 7:36 AM (125 w, 1 d)
Wed, May 25
For now we are failing one test case in LICM: Transforms/LICM/lnicm.ll. The reason is as follows. Looking at the source code:
@bmahjour I updated the patch to an NFC patch with test case updates only. I'd appreciate it if you could take a look :)
Tue, May 24
Hi Bardia @bmahjour, after some thoughts I think regarding this patch we would chase a longer-term solution. For now I think I could rework and change this patch (both title and content) to an NFC patch that only updates the test cases, i.e., from using CHECK to CHECK-NEXT, since we really want to make sure that the output is ordered and the order is correct. I'm wondering how you think about it?
Thanks for the comment!
Fri, May 20
Wed, May 18
@Meinersbur Hi Michael, I'm wondering if you have further comments? I'd appreciate it if you could let me know your thoughts on my most recent update.
Tue, May 17
Mon, May 16
Fri, May 13
Mon, May 9
Addressed reviewers' comments.
Wed, May 4
Tue, May 3
Thanks for the comments, I've updated the patch accordingly.
@bmahjour Hi Bardia, I've updated this patch to a pure NFC patch with the motivating test case only. Looking forward to your comment :)
Mon, May 2
Thanks for the comments, I've updated this patch accordingly.
Sun, May 1
Addressed Florian's comment, will land it shortly.
Sat, Apr 30
Fri, Apr 29
Landed this patch, will work on the refactoring in the next patch.
Apr 22 2022
Hi Bardia @bmahjour , my apologies that I did not clearly remember the discussion during the loopopt meeting -- was it like you would like me to commit this patch for you, or was it like you would like me to keep an eye on it after you commit it?
Apr 21 2022
Apr 20 2022
Apr 19 2022
Apr 13 2022
Apr 12 2022
Thanks for the comments! I modified the wording a bit for the title and summary, addressed the comment from Michael @Meinersbur and added test cases correspondingly, thus addressed the comment from @fhahn.
Apr 11 2022
Apr 7 2022
Apr 6 2022
Minor update to address the last comment, I'll land it shortly.
Apr 1 2022
Thanks a lot for the comments @Meinersbur! I've updated the patch accordingly.