This is an archive of the discontinued LLVM Phabricator instance.

Fix Fuchsia dyld in asan-ubsan variant
Needs ReviewPublic

Authored by shayba on Jan 2 2023, 3:31 PM.

Details

Summary

The Clang Fuchsia driver sets -dynamic-linker to ld.so.1 or to a variant if needed.
Fix the variant lib path in asan-ubsan variant.

See also:
https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=118344

Diff Detail

Event Timeline

shayba created this revision.Jan 2 2023, 3:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 2 2023, 3:31 PM
Herald added a subscriber: abrachet. · View Herald Transcript
shayba requested review of this revision.Jan 2 2023, 3:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 2 2023, 3:31 PM

I don't think we want this in the generic compiler behavior. It would only make sense if the toolchain runtimes have extra versions, and I don't think we want that many extra versions.
It may be worthwhile to change the asan multilib builds to enable ubsan checks too, but I don't think we want to support two separate asan flavors in the driver.