[BOLT] Modify the print option to a meaningful value

[hzq]

Summary

Using the option -print-sorted-by=. cause to core dump, so change to a legal value.

[hzq]

This comment was removed by hzq.

[hzq]

Update commit info.

[maksfb]

Thanks for the fix. It's better to not have this last option, but at the moment I can't think of a trivial way to make it happen.

[hzq]

In D140847#4029995, @maksfb wrote:

Thanks for the fix. It's better to not have this last option, but at the moment I can't think of a trivial way to make it happen.

Yes, that's the simplest solution I can think of, otherwise, we'll have to refactor the macro's usage. By the way, I don't have commit access, can you help with it?

[maksfb]

I was thinking about something along these lines: https://reviews.llvm.org/D141209

[hzq]

In D140847#4033822, @maksfb wrote:

I was thinking about something along these lines: https://reviews.llvm.org/D141209

Of course, this change is better, if the build problem is solved smoothly. Otherwise, I think the it's not necessary to refactor for this little problem.

bolt/lib/Passes/BinaryPasses.cpp

cl::values(clEnumValN(Peepholes::PEEP_NONE, "none", "disable peepholes"),
                           "enable all peephole optimizations")),
     cl::ZeroOrMore, cl::cat(BoltOptCategory));
 
 static cl::opt<unsigned>
     PrintFuncStat("print-function-statistics",
                   cl::desc("print statistics about basic block ordering"),
                   cl::init(0), cl::cat(BoltOptCategory));
 
-static cl::list<bolt::DynoStats::Category>
-PrintSortedBy("print-sorted-by",
-  cl::CommaSeparated,
+static cl::list<bolt::DynoStats::Category> PrintSortedBy(
+    "print-sorted-by", cl::CommaSeparated,
     cl::desc("print functions sorted by order of dyno stats"),
     cl::value_desc("key1,key2,key3,..."),
     cl::values(
 #define D(name, ...)                                        \
     clEnumValN(bolt::DynoStats::name,                     \
                dynoStatsOptName(bolt::DynoStats::name),   \
                dynoStatsOptDesc(bolt::DynoStats::name)),
         DYNO_STATS
 #undef D
-    clEnumValN(0xffff, ".", ".")
-    ),
-  cl::ZeroOrMore,
-  cl::cat(BoltOptCategory));
+            clEnumValN(bolt::DynoStats::LAST_DYNO_STAT, ".", ".")),
+    cl::ZeroOrMore, cl::cat(BoltOptCategory));
 
 static cl::opt<bool>
     PrintUnknown("print-unknown",
                  cl::desc("print names of functions with unknown control flow"),
                  cl::cat(BoltCategory), cl::Hidden);
 
 static cl::opt<bool>
     PrintUnknownCFG("print-unknown-cfg",