This is an archive of the discontinued LLVM Phabricator instance.

[APInt] Move a comment from urem to srem where it belongs.
ClosedPublic

Authored by craig.topper on Dec 23 2022, 12:21 AM.

Details

Summary

This comment talks about sign of the dividend and the result. I
think it belongs to the srem function.

This is the commit that added it
https://github.com/llvm/llvm-project/commit/709a820a5338ca5c4b949f2f0286f7da39f00661
and the code change with it was for srem.

Diff Detail

Event Timeline

craig.topper created this revision.Dec 23 2022, 12:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 23 2022, 12:21 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
craig.topper requested review of this revision.Dec 23 2022, 12:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 23 2022, 12:21 AM
nikic accepted this revision.Dec 23 2022, 12:33 AM
nikic added a subscriber: nikic.

LGTM

This revision is now accepted and ready to land.Dec 23 2022, 12:33 AM
This revision was landed with ongoing or failed builds.Dec 23 2022, 10:47 AM
This revision was automatically updated to reflect the committed changes.