This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Granularize <type_traits> includes in <compare>
ClosedPublic

Authored by philnik on Dec 21 2022, 7:16 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rGe0a66116fccc: [libc++] Granularize <type_traits> includes in <compare>

Diff Detail

Event Timeline

philnik created this revision.Dec 21 2022, 7:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 21 2022, 7:16 AM
philnik requested review of this revision.Dec 21 2022, 7:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 21 2022, 7:16 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

LGTM, thanks for the cleanup! It seems the transitive includes only add new indirect paths in older language versions, no objection from me.

libcxx/include/__memory/assume_aligned.h
17

Nice I really dislike these comments, this change makes it obsolete :-)

Mordante accepted this revision.Dec 21 2022, 8:36 AM

Now with approval ;-)

This revision is now accepted and ready to land.Dec 21 2022, 8:36 AM
philnik updated this revision to Diff 484965.Dec 22 2022, 2:30 PM

Try to fix CI

philnik updated this revision to Diff 484977.Dec 22 2022, 3:29 PM

Try to fix CI

This revision was landed with ongoing or failed builds.Dec 22 2022, 5:58 PM
This revision was automatically updated to reflect the committed changes.