This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Compute the unused includes in the check mode.
Needs ReviewPublic

Authored by hokein on Dec 14 2022, 1:34 AM.

Details

Reviewers
kadircet

Diff Detail

Event Timeline

hokein created this revision.Dec 14 2022, 1:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2022, 1:34 AM
Herald added a subscriber: arphaman. · View Herald Transcript
hokein requested review of this revision.Dec 14 2022, 1:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2022, 1:34 AM
nridge added a subscriber: nridge.Dec 18 2022, 1:04 AM

what's the motivating reason behind the change?
we'll soon change the implementation to use include-cleaner instead, and can run the tool directly to verify the findings (rather than clangd). hence i feel like this will just turn into not-so-useful extra output for clangd --check, but maybe there's some other use case that i am missing?

pmatos added a subscriber: pmatos.Jan 31 2023, 4:27 AM