This is an archive of the discontinued LLVM Phabricator instance.

Differential D139942

mlir/ods-gen: use bash from env in shell script
ClosedPublic

Authored by artagnon on Dec 13 2022, 8:32 AM.

Details

Reviewers
stellaraccident
Commits
rGbcd652855428: mlir/ods-gen: use bash from env in shell script
Summary

On macOS, hardcoding the path of bash leads to a failure in executing
update_core_linalg_named_ops.sh, due to an old version of bash being
present in that location.

Signed-off-by: Ramkumar Ramachandra <r@artagnon.com>

Diff Detail

Event Timeline

artagnon created this revision.Dec 13 2022, 8:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2022, 8:32 AM
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 20 others. · View Herald Transcript
artagnon requested review of this revision.Dec 13 2022, 8:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2022, 8:32 AM
Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B202862: Diff 482499.Dec 13 2022, 10:00 AM
stellaraccident accepted this revision.Dec 13 2022, 4:38 PM

Thanks. Do you have commit access? Or do you need help landing?

This revision is now accepted and ready to land.Dec 13 2022, 4:38 PM
artagnon added a comment.Dec 14 2022, 3:27 AM

I have commit access, no worries. Thanks for asking though! Will land momentarily.

Closed by commit rGbcd652855428: mlir/ods-gen: use bash from env in shell script (authored by artagnon). · Explain WhyDec 14 2022, 3:28 AM
This revision was automatically updated to reflect the committed changes.
artagnon added a commit: rGbcd652855428: mlir/ods-gen: use bash from env in shell script.

Revision Contents

PathSize
mlir/
tools/
mlir-linalg-ods-gen/
2 lines

Diff 482789

mlir/tools/mlir-linalg-ods-gen/update_core_linalg_named_ops.sh.in

#!/bin/bash #!/usr/bin/env bash
# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
# See https://llvm.org/LICENSE.txt for license information. # See https://llvm.org/LICENSE.txt for license information.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
# Updates the LinalgStructuredOps.yaml file based on the # Updates the LinalgStructuredOps.yaml file based on the
# core_named_ops.py source of truth. # core_named_ops.py source of truth.
set -eu -o errtrace set -eu -o errtrace
Show All 23 Lines