This is an archive of the discontinued LLVM Phabricator instance.

[RFC][OpenMP] Update to Python3 for lit test
ClosedPublic

Authored by tianshilei1992 on Dec 12 2022, 9:29 AM.

Details

Summary

I think it's reasonable to upgrade to Python 3 for LIT test requirement because lit itself (llvm/utils/lit/lit.py) already switched to Python 3. In addition, LLVM already requires Python 3.6 to be the minimum version (https://llvm.org/docs/GettingStarted.html#software).

Diff Detail

Event Timeline

tianshilei1992 created this revision.Dec 12 2022, 9:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2022, 9:29 AM
tianshilei1992 requested review of this revision.Dec 12 2022, 9:29 AM
Herald added a project: Restricted Project. · View Herald Transcript

remove development as we only need interpreter

tianshilei1992 edited the summary of this revision. (Show Details)Dec 12 2022, 9:35 AM

Probably should've discussed this at Wednesday's OpenMP meeting, I definitely think we should upgrade.

jdoerfert accepted this revision.Dec 16 2022, 10:51 AM

if llvm requires 3, let's do it.

This revision is now accepted and ready to land.Dec 16 2022, 10:51 AM
tianshilei1992 edited the summary of this revision. (Show Details)Dec 21 2022, 5:33 PM
jhuber6 accepted this revision.Dec 21 2022, 5:34 PM
This revision was automatically updated to reflect the committed changes.