This is an archive of the discontinued LLVM Phabricator instance.

[NFC] [DirectX backend] copy dxil-dis as exe file on windows
ClosedPublic

Authored by python3kgae on Dec 9 2022, 8:35 PM.

Details

Summary

Without .exe in the name on windows, the test not work.

Diff Detail

Event Timeline

python3kgae created this revision.Dec 9 2022, 8:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2022, 8:35 PM
python3kgae requested review of this revision.Dec 9 2022, 8:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2022, 8:35 PM
beanz added inline comments.Dec 9 2022, 8:50 PM
llvm/tools/dxil-dis/CMakeLists.txt
25

You should be able to use CMAKE_EXECUTABLE_SUFFIX here instead: https://cmake.org/cmake/help/latest/variable/CMAKE_EXECUTABLE_SUFFIX.html

Use CMAKE_EXECUTABLE_SUFFIX

beanz accepted this revision.Dec 13 2022, 3:21 PM

LGTM

This revision is now accepted and ready to land.Dec 13 2022, 3:21 PM
This revision was landed with ongoing or failed builds.Dec 13 2022, 4:35 PM
This revision was automatically updated to reflect the committed changes.