This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Add test that spills WWM CSRs twice
ClosedPublic

Authored by sebastian-ne on Dec 8 2022, 5:16 AM.

Details

Summary

Add a test to show a deficit in the current wwm/spilling code that
creates double saves and restores for v40 and v41.

This case came up in D124193.

Diff Detail

Event Timeline

sebastian-ne created this revision.Dec 8 2022, 5:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 8 2022, 5:16 AM
sebastian-ne requested review of this revision.Dec 8 2022, 5:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 8 2022, 5:16 AM
arsenm added inline comments.Dec 8 2022, 5:18 AM
llvm/test/CodeGen/AMDGPU/wwm-reserved-spill.ll
1374

New tests should use opaque pointers

arsenm accepted this revision.Dec 8 2022, 5:19 AM

A quick scan doesn't find any other pointers in this test file that need updating. LGTM with test fix

This revision is now accepted and ready to land.Dec 8 2022, 5:19 AM
This revision was landed with ongoing or failed builds.Dec 8 2022, 5:28 AM
This revision was automatically updated to reflect the committed changes.
sebastian-ne marked an inline comment as done.