This is an archive of the discontinued LLVM Phabricator instance.

[flang] hlfir.assign default implementation
ClosedPublic

Authored by jeanPerier on Dec 6 2022, 6:16 AM.

Details

Summary

Add the default unoptimized implementation implementation
of hlfir.assign. It relies on the runtime for array assignment
and always makes a temp of the right hand side for arrays.

Assignment optimization will be done when all HLFIR pieces are in place
and aliasing analysis is available.

Diff Detail

Event Timeline

jeanPerier created this revision.Dec 6 2022, 6:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2022, 6:16 AM
jeanPerier requested review of this revision.Dec 6 2022, 6:16 AM
This revision is now accepted and ready to land.Dec 6 2022, 6:56 AM
PeteSteinfeld accepted this revision.Dec 6 2022, 12:16 PM

Aside from the one nit, all builds and tests correctly and looks good.

flang/lib/Optimizer/HLFIR/Transforms/ConvertToFIR.cpp
266

Should read "This requires ..."

This revision was automatically updated to reflect the committed changes.
jeanPerier marked an inline comment as done.