This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Fix add_llvm_external_project()
ClosedPublic

Authored by kerberizer on Oct 21 2015, 4:53 AM.

Details

Summary

r250835 unintentionally discarded the optional parameter to the add_llvm_external_project() macro that may point to a path when the said path is different from ${name}. This should fix it by passing ${ARGN} on to add_llvm_subdirectory(). The problem manifests itself with e.g. add_llvm_external_project(clang-tools-extra extra) from clang/tools/CMakeLists.txt

References:
http://reviews.llvm.org/D13783
http://llvm.org/viewvc/llvm-project?view=revision&revision=250835

Diff Detail

Event Timeline

kerberizer updated this revision to Diff 37986.Oct 21 2015, 4:53 AM
kerberizer retitled this revision from to [CMake] Fix add_llvm_external_project().
kerberizer updated this object.
kerberizer added a subscriber: llvm-commits.
beanz edited edge metadata.Oct 21 2015, 7:20 AM
beanz added a subscriber: beanz.

LGTM. Thank you for fixing this.

-Chris

klimek accepted this revision.Oct 22 2015, 1:34 AM
klimek added a reviewer: klimek.
This revision is now accepted and ready to land.Oct 22 2015, 1:34 AM
klimek closed this revision.Oct 22 2015, 1:34 AM

Committed in r251001