This is an archive of the discontinued LLVM Phabricator instance.

InstCombine: Fold fabs (copysign x, y) -> fabs x
ClosedPublic

Authored by arsenm on Dec 5 2022, 5:09 AM.

Diff Detail

Event Timeline

arsenm created this revision.Dec 5 2022, 5:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 5 2022, 5:09 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
arsenm requested review of this revision.Dec 5 2022, 5:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 5 2022, 5:09 AM
Herald added a subscriber: wdng. · View Herald Transcript
kpn accepted this revision.Dec 5 2022, 11:20 AM

LGTM

llvm/include/llvm/IR/IRBuilder.h
946

This isn't used? Is it needed yet?

This revision is now accepted and ready to land.Dec 5 2022, 11:20 AM
arsenm added inline comments.Dec 5 2022, 11:22 AM
llvm/include/llvm/IR/IRBuilder.h
946

I have a stack of copysign patches it's used somewhere. I'll split this out to first use before pushing