This is an archive of the discontinued LLVM Phabricator instance.

Differential D139304

[LLVM][ARM] Correct llvm feature for vfpv3d16 host feature
ClosedPublic

Authored by DavidSpickett on Dec 5 2022, 2:54 AM.

Details

Reviewers
efriedma
simon_tatham
Commits
rG9f85af54d736: [LLVM][ARM] Correct llvm feature for vfpv3d16 host feature
Summary

d16 was removed in https://reviews.llvm.org/D60691.

Diff Detail

Unit TestsFailed

TimeTest
60,050 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test
60,030 msx64 debian > libFuzzer.libFuzzer::minimize_crash.test

Event Timeline

DavidSpickett created this revision.Dec 5 2022, 2:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 5 2022, 2:54 AM
Herald added subscribers: hiraditya, kristof.beyls. · View Herald Transcript
DavidSpickett requested review of this revision.Dec 5 2022, 2:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 5 2022, 2:54 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
DavidSpickett added reviewers: efriedma, simon_tatham.Dec 5 2022, 3:00 AM

For https://github.com/llvm/llvm-project/issues/59286, not sure if it's a fix though.

Harbormaster completed remote builds in B201058: Diff 480033.Dec 5 2022, 4:39 AM
efriedma accepted this revision.Dec 5 2022, 9:07 AM

LGTM

This revision is now accepted and ready to land.Dec 5 2022, 9:07 AM
This revision was landed with ongoing or failed builds.Dec 6 2022, 2:47 AM
Closed by commit rG9f85af54d736: [LLVM][ARM] Correct llvm feature for vfpv3d16 host feature (authored by DavidSpickett). · Explain Why
This revision was automatically updated to reflect the committed changes.
DavidSpickett added a commit: rG9f85af54d736: [LLVM][ARM] Correct llvm feature for vfpv3d16 host feature.

Revision Contents

PathSize
llvm/
lib/
Support/
2 lines

Diff 480033

llvm/lib/Support/Host.cpp

//===-- Host.cpp - Implement OS Host Concept --------------------*- C++ -*-===// //===-- Host.cpp - Implement OS Host Concept --------------------*- C++ -*-===//
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
▲ Show 20 Lines • Show All 1,775 Lines • ▼ Show 20 Lines#if defined(__aarch64__)
.Case("crc32", "crc") .Case("crc32", "crc")
.Case("atomics", "lse") .Case("atomics", "lse")
.Case("sve", "sve") .Case("sve", "sve")
.Case("sve2", "sve2") .Case("sve2", "sve2")
#else #else
.Case("half", "fp16") .Case("half", "fp16")
.Case("neon", "neon") .Case("neon", "neon")
.Case("vfpv3", "vfp3") .Case("vfpv3", "vfp3")
.Case("vfpv3d16", "d16") .Case("vfpv3d16", "vfp3d16")
.Case("vfpv4", "vfp4") .Case("vfpv4", "vfp4")
.Case("idiva", "hwdiv-arm") .Case("idiva", "hwdiv-arm")
.Case("idivt", "hwdiv") .Case("idivt", "hwdiv")
#endif #endif
.Default(""); .Default("");
#if defined(__aarch64__) #if defined(__aarch64__)
// We need to check crypto separately since we need all of the crypto // We need to check crypto separately since we need all of the crypto
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines