This is an archive of the discontinued LLVM Phabricator instance.

Differential D139265

[MLIR] Fix typo in `add_mlir_library` docs. NFC.
ClosedPublic

Authored by jloser on Dec 3 2022, 6:28 PM.

Details

Reviewers
rriddle
Mogball
Commits
rG1d650d4f1dd3: [MLIR] Fix typo in `add_mlir_library` docs. NFC.
Summary

s/librar/library in llvm_add_library.

Diff Detail

Event Timeline

jloser created this revision.Dec 3 2022, 6:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2022, 6:28 PM
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 19 others. · View Herald Transcript
jloser requested review of this revision.Dec 3 2022, 6:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2022, 6:28 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rriddle accepted this revision.Dec 3 2022, 6:29 PM
This revision is now accepted and ready to land.Dec 3 2022, 6:29 PM
This revision was landed with ongoing or failed builds.Dec 3 2022, 6:30 PM
Closed by commit rG1d650d4f1dd3: [MLIR] Fix typo in `add_mlir_library` docs. NFC. (authored by jloser). · Explain Why
This revision was automatically updated to reflect the committed changes.
jloser added a commit: rG1d650d4f1dd3: [MLIR] Fix typo in `add_mlir_library` docs. NFC..
Harbormaster completed remote builds in B200946: Diff 479888.Dec 3 2022, 6:58 PM

Revision Contents

PathSize
mlir/
cmake/
modules/
2 lines

Diff 479889

mlir/cmake/modules/AddMLIR.cmake

Show First 20 Lines • Show All 196 Lines • ▼ Show 20 Lines add_custom_command(
${CMAKE_CURRENT_BINARY_DIR}/${output_file}.md ${CMAKE_CURRENT_BINARY_DIR}/${output_file}.md
${GEN_DOC_FILE} ${GEN_DOC_FILE}
DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${output_file}.md) DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/${output_file}.md)
add_custom_target(${output_file}DocGen DEPENDS ${GEN_DOC_FILE}) add_custom_target(${output_file}DocGen DEPENDS ${GEN_DOC_FILE})
add_dependencies(mlir-doc ${output_file}DocGen) add_dependencies(mlir-doc ${output_file}DocGen)
endfunction() endfunction()
# Declare an mlir library which can be compiled in libMLIR.so # Declare an mlir library which can be compiled in libMLIR.so
# In addition to everything that llvm_add_librar accepts, this # In addition to everything that llvm_add_library accepts, this
# also has the following option: # also has the following option:
# EXCLUDE_FROM_LIBMLIR # EXCLUDE_FROM_LIBMLIR
# Don't include this library in libMLIR.so. This option should be used # Don't include this library in libMLIR.so. This option should be used
# for test libraries, executable-specific libraries, or rarely used libraries # for test libraries, executable-specific libraries, or rarely used libraries
# with large dependencies. # with large dependencies.
# ENABLE_AGGREGATION # ENABLE_AGGREGATION
# Forces generation of an OBJECT library, exports additional metadata, # Forces generation of an OBJECT library, exports additional metadata,
# and installs additional object files needed to include this as part of an # and installs additional object files needed to include this as part of an
▲ Show 20 Lines • Show All 419 Lines • Show Last 20 Lines