Details
- Reviewers
ldionne Mordante var-const huixie90 - Group Reviewers
Restricted Project - Commits
- rG66ba7c32add0: [libc++] Granularize <type_traits> includes in <concepts>
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Thanks for the cleanup! One question.
libcxx/test/libcxx/ranges/range.utility.helpers/different_from.compile.pass.cpp | ||
---|---|---|
21 | What is the benefit of using a private header here? |
libcxx/test/libcxx/ranges/range.utility.helpers/different_from.compile.pass.cpp | ||
---|---|---|
21 | I assume it's because there is no std::different_from, it's just a useful private concept that we have unit tests for. I'm not sure this is the most appropriate home for these tests nested in ranges/range.utility.helpers as it's more generic than that (isomorphic to std::same_as). |
Try to fix CI
libcxx/test/libcxx/ranges/range.utility.helpers/different_from.compile.pass.cpp | ||
---|---|---|
21 | We check that <__concpet/different_from.h> is self-contained. We might as well, since we test implementation details anyways. |
One request other than that LGTM.
libcxx/test/libcxx/ranges/range.utility.helpers/different_from.compile.pass.cpp | ||
---|---|---|
21 | We typically don't do that, so IMO it would be good to add a comment like Check that <__concpet/different_from.h> is self-contained. |
libcxx/include/__type_traits/remove_cvref.h | ||
---|---|---|
15 | Does the header include itself now? Can we please remove this? |
libcxx/include/__type_traits/remove_cvref.h | ||
---|---|---|
15 | Nice catch! |
libcxx/include/__type_traits/remove_cvref.h | ||
---|---|---|
15 | I went ahead and removed this in 0c6e74fa744b0e6abe3614af55f4f9dd1fbc54b2. |
Does the header include itself now?
Can we please remove this?