This is an archive of the discontinued LLVM Phabricator instance.

Differential D139071

[mlir][spirv] Fix missing parameter usage
ClosedPublic

Authored by antiagainst on Nov 30 2022, 8:17 PM.

Details

Reviewers
kuhar
ThomasRaoux
nicolasvasilache
Commits
rGda5903eb69c1: [mlir][spirv] Fix missing parameter usage
Summary

This was accidentially removed during refactoring.

Diff Detail

Event Timeline

antiagainst created this revision.Nov 30 2022, 8:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2022, 8:17 PM
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 20 others. · View Herald Transcript
antiagainst requested review of this revision.Nov 30 2022, 8:17 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptNov 30 2022, 8:17 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
kuhar accepted this revision.Nov 30 2022, 8:34 PM
This revision is now accepted and ready to land.Nov 30 2022, 8:34 PM
Harbormaster completed remote builds in B200415: Diff 479148.Nov 30 2022, 8:57 PM
Closed by commit rGda5903eb69c1: [mlir][spirv] Fix missing parameter usage (authored by antiagainst). · Explain WhyNov 30 2022, 9:05 PM
This revision was automatically updated to reflect the committed changes.
antiagainst added a commit: rGda5903eb69c1: [mlir][spirv] Fix missing parameter usage.

Revision Contents

PathSize
mlir/
lib/
Dialect/
SPIRV/
IR/
2 lines

Diff 479156

mlir/lib/Dialect/SPIRV/IR/TargetAndABI.cpp

Show First 20 Lines • Show All 123 Lines • ▼ Show 20 Linesspirv::getEntryPointABIAttr(MLIRContext *context,
ArrayRef<int32_t> workgroupSize, ArrayRef<int32_t> workgroupSize,
llvm::Optional<int> subgroupSize) { llvm::Optional<int> subgroupSize) {
DenseI32ArrayAttr workgroupSizeAttr; DenseI32ArrayAttr workgroupSizeAttr;
if (!workgroupSize.empty()) { if (!workgroupSize.empty()) {
assert(workgroupSize.size() == 3); assert(workgroupSize.size() == 3);
workgroupSizeAttr = DenseI32ArrayAttr::get(context, workgroupSize); workgroupSizeAttr = DenseI32ArrayAttr::get(context, workgroupSize);
} }
return spirv::EntryPointABIAttr::get(context, workgroupSizeAttr, return spirv::EntryPointABIAttr::get(context, workgroupSizeAttr,
/*subgroupSize=*/llvm::None); subgroupSize);
} }
spirv::EntryPointABIAttr spirv::lookupEntryPointABI(Operation *op) { spirv::EntryPointABIAttr spirv::lookupEntryPointABI(Operation *op) {
while (op && !isa<FunctionOpInterface>(op)) while (op && !isa<FunctionOpInterface>(op))
op = op->getParentOp(); op = op->getParentOp();
if (!op) if (!op)
return {}; return {};
▲ Show 20 Lines • Show All 103 Lines • Show Last 20 Lines