This is an archive of the discontinued LLVM Phabricator instance.

Fixed a few spelling errors in clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td
Needs ReviewPublic

Authored by giannicrivello on Nov 29 2022, 5:28 PM.

Details

Summary

Fixed spelling errors in said file. I am also new to LLVM contribution so I wanted to test the waters and make a small commit before taking on bigger projects.

Diff Detail

Event Timeline

giannicrivello created this revision.Nov 29 2022, 5:28 PM
Herald added a project: Restricted Project. · View Herald Transcript
giannicrivello requested review of this revision.Nov 29 2022, 5:28 PM
giannicrivello set the repository for this revision to rG LLVM Github Monorepo.Nov 29 2022, 5:31 PM
NoQ added a comment.Nov 29 2022, 6:38 PM

Nice, thanks!

For non-trivial patches it's recommended to include full diff context via -U999999 (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface) so that reviewers could easily see what does the surrounding code do.

clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td
30

This one's probably intentional!

Nice, thanks!

For non-trivial patches it's recommended to include full diff context via -U999999 (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface) so that reviewers could easily see what does the surrounding code do.

Ok will do, thanks. So how would I move forward from here?

clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td
30

I see what they did there. lol

NoQ added a comment.Nov 29 2022, 7:50 PM

So how would I move forward from here?

There's the "Update Diff" button on the right! You can use it to address review comments until everyone's happy.

tbaeder added inline comments.Nov 29 2022, 10:49 PM
clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td
102

Sure that "name" and "fullname" here aren't actual field names in the code?

Addressed the intentional spelling errors, also fixed a few more grammar errors

tbaeder resigned from this revision.Jul 1 2023, 10:48 PM