Fixed spelling errors in said file. I am also new to LLVM contribution so I wanted to test the waters and make a small commit before taking on bigger projects.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Nice, thanks!
For non-trivial patches it's recommended to include full diff context via -U999999 (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface) so that reviewers could easily see what does the surrounding code do.
clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td | ||
---|---|---|
30 | This one's probably intentional! |
Comment Actions
Ok will do, thanks. So how would I move forward from here?
clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td | ||
---|---|---|
30 | I see what they did there. lol |
Comment Actions
So how would I move forward from here?
There's the "Update Diff" button on the right! You can use it to address review comments until everyone's happy.
clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td | ||
---|---|---|
102 | Sure that "name" and "fullname" here aren't actual field names in the code? |
This one's probably intentional!