This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] add missing Armv8.9-A -> Armv9.4-A equivalence test
AcceptedPublic

Authored by stuij on Nov 29 2022, 3:27 AM.

Details

Diff Detail

Event Timeline

stuij created this revision.Nov 29 2022, 3:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 3:27 AM
stuij requested review of this revision.Nov 29 2022, 3:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 3:27 AM
tmatheson accepted this revision.Nov 29 2022, 6:45 AM
This revision is now accepted and ready to land.Nov 29 2022, 6:45 AM

LGTM, but this test will be removed by D138792, which I am hoping to land soon.

Is this out-of-date again?

stuij added a comment.Jan 25 2023, 8:50 AM

I meant to mark this as dropped after Tomas' comment, but searching through the codebase I don't see any tests for convert<X>to<Y>. Are those not needed at all anymore, or were they accidentally cut?

I think we have tests for implies now? I'm not sure what the equivalent API is.

Yes this case is tested for implies(): EXPECT_TRUE(AArch64::ARMV9_4A.implies(AArch64::ARMV8_9A));

lenary resigned from this revision.Apr 13 2023, 10:00 AM