This is an archive of the discontinued LLVM Phabricator instance.

I meant to mark this as dropped after Tomas' comment, but searching through the codebase I don't see any tests for convert<X>to<Y>. Are those not needed at all anymore, or were they accidentally cut?

I think we have tests for implies now? I'm not sure what the equivalent API is.

@tmatheson -^ ?

Yes this case is tested for implies(): EXPECT_TRUE(AArch64::ARMV9_4A.implies(AArch64::ARMV8_9A));

lenary resigned from this revision.Apr 13 2023, 10:00 AM

Revision Contents

Path

Size

llvm/

unittests/

Support/

TargetParserTest.cpp

2 lines

Diff 478503

llvm/unittests/Support/TargetParserTest.cpp

//===----------- TargetParser.cpp - Target Parser -------------------------===//		//===----------- TargetParser.cpp - Target Parser -------------------------===//
		Lint: Lint Inline Actions clang-format not found in user’s local PATH; not linting file. Lint: Lint: clang-format not found in user’s local PATH; not linting file.
//		//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.		// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.		// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception		// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//		//
//===----------------------------------------------------------------------===//		//===----------------------------------------------------------------------===//

▲ Show 20 Lines • Show All 1,699 Lines • ▼ Show 20 Lines	TEST(TargetParserTest, AArch64ArchV9toV8Conversion) {
EXPECT_EQ(AArch64::ArchKind::ARMV8_5A,		EXPECT_EQ(AArch64::ArchKind::ARMV8_5A,
AArch64::convertV9toV8(AArch64::ArchKind::ARMV9A));		AArch64::convertV9toV8(AArch64::ArchKind::ARMV9A));
EXPECT_EQ(AArch64::ArchKind::ARMV8_6A,		EXPECT_EQ(AArch64::ArchKind::ARMV8_6A,
AArch64::convertV9toV8(AArch64::ArchKind::ARMV9_1A));		AArch64::convertV9toV8(AArch64::ArchKind::ARMV9_1A));
EXPECT_EQ(AArch64::ArchKind::ARMV8_7A,		EXPECT_EQ(AArch64::ArchKind::ARMV8_7A,
AArch64::convertV9toV8(AArch64::ArchKind::ARMV9_2A));		AArch64::convertV9toV8(AArch64::ArchKind::ARMV9_2A));
EXPECT_EQ(AArch64::ArchKind::ARMV8_8A,		EXPECT_EQ(AArch64::ArchKind::ARMV8_8A,
AArch64::convertV9toV8(AArch64::ArchKind::ARMV9_3A));		AArch64::convertV9toV8(AArch64::ArchKind::ARMV9_3A));
		EXPECT_EQ(AArch64::ArchKind::ARMV8_9A,
		AArch64::convertV9toV8(AArch64::ArchKind::ARMV9_4A));
}		}

TEST(TargetParserTest, AArch64ArchExtFeature) {		TEST(TargetParserTest, AArch64ArchExtFeature) {
const char *ArchExt[][4] = {		const char *ArchExt[][4] = {
{"crc", "nocrc", "+crc", "-crc"},		{"crc", "nocrc", "+crc", "-crc"},
{"crypto", "nocrypto", "+crypto", "-crypto"},		{"crypto", "nocrypto", "+crypto", "-crypto"},
{"flagm", "noflagm", "+flagm", "-flagm"},		{"flagm", "noflagm", "+flagm", "-flagm"},
{"fp", "nofp", "+fp-armv8", "-fp-armv8"},		{"fp", "nofp", "+fp-armv8", "-fp-armv8"},
▲ Show 20 Lines • Show All 47 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] add missing Armv8.9-A -> Armv9.4-A equivalence testAcceptedPublic

Details

Diff Detail

Unit TestsFailed

Event Timeline

Revision Contents

Diff 478503

llvm/unittests/Support/TargetParserTest.cpp

[AArch64] add missing Armv8.9-A -> Armv9.4-A equivalence test
AcceptedPublic