[AArch64] add missing Armv8.9-A -> Armv9.4-A equivalence test
AcceptedPublic
Actions

Authored by stuij on Nov 29 2022, 3:27 AM.

Details

Reviewers

tmatheson
lenary
pratlucas

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	1,000 ms	x64 debian > LLVM.Examples/OrcV2Examples::lljit-with-thinlto-summaries.test Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -module-summary /var/lib/buildkite-agent/builds/llvm-project/llvm/test/Examples/OrcV2Examples/Inputs/main-mod.ll -o /var/lib/buildkite-agent/builds/llvm-project/build/test/Examples/OrcV2Examples/Output/main-mod.bc
	60,050 ms	x64 debian > libFuzzer.libFuzzer::minimize_crash.test Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/NullDerefTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/minimize_crash.test.tmp-NullDerefTest

Event Timeline

stuij created this revision.Nov 29 2022, 3:27 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 3:27 AM

Herald added a subscriber: kristof.beyls. · View Herald Transcript

stuij requested review of this revision.Nov 29 2022, 3:27 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 3:27 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B199968: Diff 478503.Nov 29 2022, 4:17 AM

stuij added reviewers: tmatheson, lenary, pratlucas.Nov 29 2022, 5:51 AM

tmatheson accepted this revision.Nov 29 2022, 6:45 AM

This revision is now accepted and ready to land.Nov 29 2022, 6:45 AM

LGTM, but this test will be removed by D138792, which I am hoping to land soon.

Is this out-of-date again?

I meant to mark this as dropped after Tomas' comment, but searching through the codebase I don't see any tests for convert<X>to<Y>. Are those not needed at all anymore, or were they accidentally cut?

I think we have tests for implies now? I'm not sure what the equivalent API is.

@tmatheson -^ ?

Yes this case is tested for implies(): EXPECT_TRUE(AArch64::ARMV9_4A.implies(AArch64::ARMV8_9A));

Revision Contents
Changeset List

Path

Size

llvm/

unittests/

Support/

TargetParserTest.cpp

2 lines

Diff 478503

View Options

llvm/unittests/Support/TargetParserTest.cpp

[AArch64] add missing Armv8.9-A -> Armv9.4-A equivalence testAcceptedPublicActions