Page MenuHomePhabricator

[clang] Propely handle tests for open DRs in make_cxx_dr_status
ClosedPublic

Authored by Endill on Nov 29 2022, 12:21 AM.

Details

Summary

A follow-up to D136133. It was mentioned in #58382 that there is a need to test for DRs that have not been officially resolved yet. This patch aims to replace original "hackery" with proper handling for such cases. Highlights:

  • Availability can be suffixed (further) with "open", "drafting", or "review", e.g. // dr2565: 16 open, // drXXXX: 16 c++17 drafting
  • Checks are implemented to ensure that this suffix corresponds to actual issue status
  • Non-resolved DRs are counted (stdout of make_cxx_dr_status)
  • No changes made to cxx_dr_status.html
  • 'c++20' availability suffix added
  • Remove 'concurrency' status since it's no longer on the list of statuses in CWG Active Issues

Diff Detail

Event Timeline

Endill created this revision.Nov 29 2022, 12:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 12:21 AM
Endill requested review of this revision.Nov 29 2022, 12:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2022, 12:21 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

I like the change, thank you! I don't see anything to be concerned about, but my python is awful, so I'd like at least a 2nd set of eyes to take a look.

aaron.ballman added a subscriber: aaron.ballman.

LGTM though my Python skills are lacking, so additional eyeballs on that would be appreciated.

clang/www/make_cxx_dr_status
187–189

Thank you for this! It resolves the biggest concern I had with our markings getting out of sync with the issues list.

This revision is now accepted and ready to land.Nov 29 2022, 6:22 AM

Can I kindly ask you to commit this?
I guess I can ask for commit access after this patch, and not bother you any further.

I don't see anything wrong with the python either. There are probably clever ways to deal with the successions of if statements but i don't think it would be worth it.

cor3ntin accepted this revision.Nov 29 2022, 6:45 AM

Thanks @cor3ntin , I'll commit this then.

This revision was landed with ongoing or failed builds.Nov 29 2022, 6:47 AM
This revision was automatically updated to reflect the committed changes.

I'd also use newlines more liberally since the two-space indentation is pretty dense already.

clang/www/make_cxx_dr_status
190–191

These two lines are the same with the end of the else-branch, i.e. they could both be lifted out of the if-clause and unified at the end.

198–199