This is an archive of the discontinued LLVM Phabricator instance.

[Clang] update cxx_dr_status.html by running make_cxx_dr_status
ClosedPublic

Authored by ychen on Oct 17 2022, 11:28 PM.

Diff Detail

Event Timeline

ychen created this revision.Oct 17 2022, 11:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2022, 11:28 PM
ychen requested review of this revision.Oct 17 2022, 11:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2022, 11:28 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
ychen updated this revision to Diff 468430.Oct 17 2022, 11:35 PM
  • rebase

Thank you so much for doing this. I'm hopeful our hackery can go away sometime soon.

clang/test/CXX/drs/dr25xx.cpp
3

If you could add a comment explaining this status for me, I would be grateful:

// We've implemented DR2565 as proposed (that is, a substitution failure in a requires parameter list causes the requires clause to evaluate as false) as it seems to make the most sense, and fit best into our implementation. If this issue gets accepted as-is, this can be marked as complete.

clang/www/make_cxx_dr_status
161–164

I guess this is OK, its a shame we have to custom-tag these, but I guess I'm 1/2 responsible here :/

ychen added inline comments.Oct 18 2022, 10:57 AM
clang/test/CXX/drs/dr25xx.cpp
3

You said we were in a position where we had 1/2 of it implemented. So I put it as partial. I must've misunderstood you. Will change it back.

clang/www/make_cxx_dr_status
161–164

Yeah, it looks hacky. If the list gets larger, we could do something like namespace dr1432 { // dr1432: open 16 to make it more general.

ychen updated this revision to Diff 468631.Oct 18 2022, 11:27 AM
  • DR2565 is fully implemented.
ychen marked an inline comment as done.Oct 18 2022, 11:27 AM
erichkeane accepted this revision.Oct 18 2022, 11:28 AM

SGTM with teh changes discussed above

This revision is now accepted and ready to land.Oct 18 2022, 11:28 AM
This revision was landed with ongoing or failed builds.Oct 18 2022, 11:45 AM
This revision was automatically updated to reflect the committed changes.