This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Convert a test to generated checks
ClosedPublic

Authored by arsenm on Nov 28 2022, 7:06 AM.

Details

Reviewers
rampitec
foad
Pierre-vh
Group Reviewers
Restricted Project
Summary

Also switch to not using kernels to test, since it shouldn't matter
for these addressing modes. This should reduce some of the diffs
between subtargets, but it's still not enough to share the same
checks.

The test could use some additional modernization. Probably should also
round this out with the new maximium offsets.

Diff Detail

Event Timeline

arsenm created this revision.Nov 28 2022, 7:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2022, 7:06 AM
arsenm requested review of this revision.Nov 28 2022, 7:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 28 2022, 7:06 AM
Herald added a subscriber: wdng. · View Herald Transcript
foad accepted this revision.Dec 5 2022, 9:14 AM

LGTM.

This revision is now accepted and ready to land.Dec 5 2022, 9:14 AM