This is an archive of the discontinued LLVM Phabricator instance.

Differential D138735

[mlir][spirv] Enable WebGPU to use UnifyAliasedResourcePass
ClosedPublic

Authored by antiagainst on Nov 25 2022, 1:29 PM.

Details

Reviewers
kuhar
nicolasvasilache
Commits
rG234d2e27db2e: [mlir][spirv] Enable WebGPU to use UnifyAliasedResourcePass
Summary

When targeting WebGPU, we also need to transcompile SPIR-V, into
WGSL this time. We have similar limitations there like when
targeting Metal or MoltenVK.

Diff Detail

Event Timeline

antiagainst created this revision.Nov 25 2022, 1:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 25 2022, 1:29 PM
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 22 others. · View Herald Transcript
antiagainst requested review of this revision.Nov 25 2022, 1:29 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptNov 25 2022, 1:29 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B199593: Diff 478018.Nov 25 2022, 1:45 PM
kuhar accepted this revision.Nov 25 2022, 1:50 PM
This revision is now accepted and ready to land.Nov 25 2022, 1:50 PM
This revision was landed with ongoing or failed builds.Nov 25 2022, 1:56 PM
Closed by commit rG234d2e27db2e: [mlir][spirv] Enable WebGPU to use UnifyAliasedResourcePass (authored by antiagainst). · Explain Why
This revision was automatically updated to reflect the committed changes.
antiagainst added a commit: rG234d2e27db2e: [mlir][spirv] Enable WebGPU to use UnifyAliasedResourcePass.

Revision Contents

PathSize
mlir/
lib/
Dialect/
SPIRV/
Transforms/
14 lines

Diff 478021

mlir/lib/Dialect/SPIRV/Transforms/UnifyAliasedResourcePass.cpp

Show First 20 Lines • Show All 543 Lines • ▼ Show 20 Lines
}; };
} // namespace } // namespace
void UnifyAliasedResourcePass::runOnOperation() { void UnifyAliasedResourcePass::runOnOperation() {
spirv::ModuleOp moduleOp = getOperation(); spirv::ModuleOp moduleOp = getOperation();
MLIRContext *context = &getContext(); MLIRContext *context = &getContext();
if (getTargetEnvFn) { if (getTargetEnvFn) {
// This pass is actually only needed for targeting Apple GPUs via MoltenVK, // This pass is only needed for targeting WebGPU, Metal, or layering Vulkan
// where we need to translate SPIR-V into MSL. The translation has // on Metal via MoltenVK, where we need to translate SPIR-V into WGSL or
// limitations. // MSL. The translation has limitations.
if (getTargetEnvFn(moduleOp).getVendorID() != spirv::Vendor::Apple) spirv::TargetEnvAttr targetEnv = getTargetEnvFn(moduleOp);
spirv::ClientAPI clientAPI = targetEnv.getClientAPI();
bool isVulkanOnAppleDevices =
clientAPI == spirv::ClientAPI::Vulkan &&
targetEnv.getVendorID() == spirv::Vendor::Apple;
if (clientAPI != spirv::ClientAPI::WebGPU &&
clientAPI != spirv::ClientAPI::Metal && !isVulkanOnAppleDevices)
return; return;
} }
// Analyze aliased resources first. // Analyze aliased resources first.
ResourceAliasAnalysis &analysis = getAnalysis<ResourceAliasAnalysis>(); ResourceAliasAnalysis &analysis = getAnalysis<ResourceAliasAnalysis>();
ConversionTarget target(*context); ConversionTarget target(*context);
target.addDynamicallyLegalOp<spirv::GlobalVariableOp, spirv::AddressOfOp, target.addDynamicallyLegalOp<spirv::GlobalVariableOp, spirv::AddressOfOp,
Show All 28 Lines