This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SME]: Add streaming-compatible testing files(subvector.ll, permute-rev.ll, permute-zip-uzp-trn.ll, vector-shuffle.ll)
ClosedPublic

Authored by hassnaa-arm on Nov 24 2022, 11:54 AM.

Details

Summary

Testing files:

  • subvector.ll
  • permute-rev.ll
  • permute-zip-uzp-trn.ll
  • vector-shuffle.ll

Diff Detail

Event Timeline

hassnaa-arm created this revision.Nov 24 2022, 11:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 24 2022, 11:54 AM
hassnaa-arm requested review of this revision.Nov 24 2022, 11:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 24 2022, 11:54 AM

Update by main branch

hassnaa-arm edited the summary of this revision. (Show Details)Nov 25 2022, 5:48 AM
Matt added a subscriber: Matt.Nov 27 2022, 10:36 AM
david-arm accepted this revision.Nov 29 2022, 1:57 AM

LGTM with comments addressed!

llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-permute-rev.ll
165

nit: Perhaps best to delete this comment before landing?

llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-vector-shuffle.ll
7

nit: Can you remove this commented out code?

This revision is now accepted and ready to land.Nov 29 2022, 1:57 AM
hassnaa-arm marked 2 inline comments as done.Nov 29 2022, 3:16 AM

Uncomment commented tests and rerun the test cases

sdesmalen added inline comments.Nov 29 2022, 7:03 AM
llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-permute-rev.ll
184

This one could be handled with revd which was added in SME and/or SVE2p1. If you change the attributes for this to function to e.g. attributes #1 = { "target-features"="+sve2p1" }, then I would expect better code for this. Can you try that?

241

Given that the above case isn't handled by any rev instruction, I don't see much value in this test.
Same holds for all the other @test_rev<type>_256 tests below.

410

I don't think this one is very different from @test_revv8i32, so you can probably remove it.

456

I don't think this one is very different from @test_revv8i32, so you can probably remove it.

491

I'm also not sure what this test and the one below are testing, maybe they can also be removed?

llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-subvector.ll
4

Can you keep the original comment from sve-fixed-length-subvector.ll:

; Test we can code generater patterns of the form:
;   fixed_length_vector = ISD::EXTRACT_SUBVECTOR scalable_vector, 0
;   scalable_vector = ISD::INSERT_SUBVECTOR scalable_vector, fixed_length_vector, 0
; 
; NOTE: Currently shufflevector does not support scalable vectors so it cannot
; be used to model the above operations.  Instead these tests rely on knowing
; how fixed length operation are lowered to scalable ones, with multiple blocks
; ensuring insert/extract sequences are not folded away.

Without that comment, this test doesn't make much sense since it's just loading and storing data, yet the name of the test suggests something different.

8

We can just use opaque pointers here (ptr instead of <4 x i8>*), please change that here and in the rest of this file.

hassnaa-arm retitled this revision from [AArch64][SME]: Add streaming-compatible testing files. to [AArch64][SME]: Add streaming-compatible testing files(subvector.ll, permute-rev.ll, permute-zip-uzp-trn.ll, ector-shuffle.ll).Nov 30 2022, 1:23 AM
hassnaa-arm retitled this revision from [AArch64][SME]: Add streaming-compatible testing files(subvector.ll, permute-rev.ll, permute-zip-uzp-trn.ll, ector-shuffle.ll) to [AArch64][SME]: Add streaming-compatible testing files(subvector.ll, permute-rev.ll, permute-zip-uzp-trn.ll, vector-shuffle.ll).Nov 30 2022, 1:28 AM
hassnaa-arm marked 6 inline comments as done.Nov 30 2022, 1:42 AM
hassnaa-arm added inline comments.
llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-permute-rev.ll
184

I tried it, but nothing changed.

Remove unneeded test cases

Use opaque PTRs

sdesmalen accepted this revision.Nov 30 2022, 8:06 AM
sdesmalen added inline comments.
llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-permute-rev.ll
184

Okay, that will probably need a few more changes then, thanks for checking.

This revision was landed with ongoing or failed builds.Nov 30 2022, 4:52 PM
This revision was automatically updated to reflect the committed changes.