This is an archive of the discontinued LLVM Phabricator instance.

Differential D138569

[WebAssembly] Remove unnecessary GEP insts from table tests
ClosedPublic

Authored by pmatos on Nov 23 2022, 5:09 AM.

Details

Reviewers
asb
tlively
Commits
rGbab98395a103: [WebAssembly] Remove unnecessary GEP insts from table tests
Summary

Removes the unnecessary GEP instructions from WebAssembly Table tests.

Diff Detail

Event Timeline

pmatos created this revision.Nov 23 2022, 5:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 23 2022, 5:09 AM
Herald added subscribers: StephenFan, wingo, ecnelises and 4 others. · View Herald Transcript
pmatos requested review of this revision.Nov 23 2022, 5:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 23 2022, 5:09 AM
Herald added subscribers: llvm-commits, aheejin. · View Herald Transcript
Harbormaster completed remote builds in B199182: Diff 477469.Nov 23 2022, 6:07 AM
tlively accepted this revision.Nov 23 2022, 6:30 AM
This revision is now accepted and ready to land.Nov 23 2022, 6:30 AM
asb accepted this revision.Nov 23 2022, 8:18 AM
Closed by commit rGbab98395a103: [WebAssembly] Remove unnecessary GEP insts from table tests (authored by pmatos). · Explain WhyNov 23 2022, 9:46 AM
This revision was automatically updated to reflect the committed changes.
pmatos added a commit: rGbab98395a103: [WebAssembly] Remove unnecessary GEP insts from table tests.

Revision Contents

PathSize
llvm/
test/
CodeGen/
WebAssembly/
7 lines
3 lines
3 lines
3 lines

Diff 477543

llvm/test/CodeGen/WebAssembly/table-copy.ll

Show All 9 Lines
define void @table_copy(i32 %dst, i32 %src, i32 %len) { define void @table_copy(i32 %dst, i32 %src, i32 %len) {
; CHECK-LABEL: table_copy: ; CHECK-LABEL: table_copy:
; CHECK-NEXT: .functype table_copy (i32, i32, i32) -> () ; CHECK-NEXT: .functype table_copy (i32, i32, i32) -> ()
; CHECK-NEXT: local.get 0 ; CHECK-NEXT: local.get 0
; CHECK-NEXT: local.get 1 ; CHECK-NEXT: local.get 1
; CHECK-NEXT: local.get 2 ; CHECK-NEXT: local.get 2
; CHECK-NEXT: table.copy externref_table1, externref_table2 ; CHECK-NEXT: table.copy externref_table1, externref_table2
; CHECK-NEXT: end_function ; CHECK-NEXT: end_function
%tableptr1 = getelementptr [0 x %externref], ptr addrspace(1) @externref_table1, i32 0, i32 0 call void @llvm.wasm.table.copy(ptr addrspace(1) @externref_table1, ptr addrspace(1) @externref_table2, i32 %dst, i32 %src, i32 %len)
%tableptr2 = getelementptr [0 x %externref], ptr addrspace(1) @externref_table2, i32 0, i32 0
call void @llvm.wasm.table.copy(ptr addrspace(1) %tableptr1, ptr addrspace(1) %tableptr2, i32 %dst, i32 %src, i32 %len)
ret void ret void
} }
; Testing copying from a table to itself at different offsets ; Testing copying from a table to itself at different offsets
; Copies len items from table1 at src to table1 at src+off ; Copies len items from table1 at src to table1 at src+off
define void @self_table_copy(i32 %src, i32 %off, i32 %len) { define void @self_table_copy(i32 %src, i32 %off, i32 %len) {
; CHECK-LABEL: self_table_copy: ; CHECK-LABEL: self_table_copy:
; CHECK-NEXT: .functype self_table_copy (i32, i32, i32) -> () ; CHECK-NEXT: .functype self_table_copy (i32, i32, i32) -> ()
; CHECK-NEXT: local.get 0 ; CHECK-NEXT: local.get 0
; CHECK-NEXT: local.get 1 ; CHECK-NEXT: local.get 1
; CHECK-NEXT: i32.add ; CHECK-NEXT: i32.add
; CHECK-NEXT: local.get 0 ; CHECK-NEXT: local.get 0
; CHECK-NEXT: local.get 2 ; CHECK-NEXT: local.get 2
; CHECK-NEXT: table.copy externref_table1, externref_table1 ; CHECK-NEXT: table.copy externref_table1, externref_table1
; CHECK-NEXT: end_function ; CHECK-NEXT: end_function
%dst = add nsw i32 %src, %off %dst = add nsw i32 %src, %off
%tableptr1 = getelementptr [0 x %externref], ptr addrspace(1) @externref_table1, i32 0, i32 0 call void @llvm.wasm.table.copy(ptr addrspace(1) @externref_table1, ptr addrspace(1) @externref_table1, i32 %dst, i32 %src, i32 %len)
call void @llvm.wasm.table.copy(ptr addrspace(1) %tableptr1, ptr addrspace(1) %tableptr1, i32 %dst, i32 %src, i32 %len)
ret void ret void
} }

llvm/test/CodeGen/WebAssembly/table-fill.ll

; RUN: llc --mtriple=wasm32-unknown-unknown -asm-verbose=false -mattr=+reference-types < %s | FileCheck %s ; RUN: llc --mtriple=wasm32-unknown-unknown -asm-verbose=false -mattr=+reference-types < %s | FileCheck %s
%externref = type ptr addrspace(10) ;; addrspace 10 is nonintegral %externref = type ptr addrspace(10) ;; addrspace 10 is nonintegral
@externref_table = local_unnamed_addr addrspace(1) global [0 x %externref] undef @externref_table = local_unnamed_addr addrspace(1) global [0 x %externref] undef
declare void @llvm.wasm.table.fill.externref(ptr addrspace(1), i32, %externref, i32) nounwind readonly declare void @llvm.wasm.table.fill.externref(ptr addrspace(1), i32, %externref, i32) nounwind readonly
define void @table_fill(i32 %start, i32 %len, %externref %val) { define void @table_fill(i32 %start, i32 %len, %externref %val) {
; CHECK-LABEL: table_fill: ; CHECK-LABEL: table_fill:
; CHECK-NEXT: .functype table_fill (i32, i32, externref) -> () ; CHECK-NEXT: .functype table_fill (i32, i32, externref) -> ()
; CHECK-NEXT: local.get 0 ; CHECK-NEXT: local.get 0
; CHECK-NEXT: local.get 2 ; CHECK-NEXT: local.get 2
; CHECK-NEXT: local.get 1 ; CHECK-NEXT: local.get 1
; CHECK-NEXT: table.fill externref_table ; CHECK-NEXT: table.fill externref_table
; CHECK-NEXT: end_function ; CHECK-NEXT: end_function
%tableptr = getelementptr [0 x %externref], ptr addrspace(1) @externref_table, i32 0, i32 0 call void @llvm.wasm.table.fill.externref(ptr addrspace(1) @externref_table, i32 %start, %externref %val, i32 %len)
call void @llvm.wasm.table.fill.externref(ptr addrspace(1) %tableptr, i32 %start, %externref %val, i32 %len)
ret void ret void
} }

llvm/test/CodeGen/WebAssembly/table-grow.ll

Show All 9 Lines
define i32 @table_grow(i32 %sz) { define i32 @table_grow(i32 %sz) {
; CHECK-LABEL: table_grow: ; CHECK-LABEL: table_grow:
; CHECK-NEXT: .functype table_grow (i32) -> (i32) ; CHECK-NEXT: .functype table_grow (i32) -> (i32)
; CHECK-NEXT: ref.null_extern ; CHECK-NEXT: ref.null_extern
; CHECK-NEXT: local.get 0 ; CHECK-NEXT: local.get 0
; CHECK-NEXT: table.grow externref_table ; CHECK-NEXT: table.grow externref_table
; CHECK-NEXT: end_function ; CHECK-NEXT: end_function
%null = call %externref @llvm.wasm.ref.null.extern() %null = call %externref @llvm.wasm.ref.null.extern()
%tableptr = getelementptr [0 x %externref], ptr addrspace(1) @externref_table, i32 0, i32 0 %newsz = call i32 @llvm.wasm.table.grow.externref(ptr addrspace(1) @externref_table, %externref %null, i32 %sz)
%newsz = call i32 @llvm.wasm.table.grow.externref(ptr addrspace(1) %tableptr, %externref %null, i32 %sz)
ret i32 %newsz ret i32 %newsz
} }

llvm/test/CodeGen/WebAssembly/table-size.ll

; RUN: llc --mtriple=wasm32-unknown-unknown -asm-verbose=false -mattr=+reference-types < %s | FileCheck %s ; RUN: llc --mtriple=wasm32-unknown-unknown -asm-verbose=false -mattr=+reference-types < %s | FileCheck %s
%externref = type ptr addrspace(10) ;; addrspace 10 is nonintegral %externref = type ptr addrspace(10) ;; addrspace 10 is nonintegral
@externref_table = local_unnamed_addr addrspace(1) global [0 x %externref] undef @externref_table = local_unnamed_addr addrspace(1) global [0 x %externref] undef
declare i32 @llvm.wasm.table.size(ptr addrspace(1)) nounwind readonly declare i32 @llvm.wasm.table.size(ptr addrspace(1)) nounwind readonly
define i32 @table_size() { define i32 @table_size() {
; CHECK-LABEL: table_size: ; CHECK-LABEL: table_size:
; CHECK-NEXT: .functype table_size () -> (i32) ; CHECK-NEXT: .functype table_size () -> (i32)
; CHECK-NEXT: table.size externref_table ; CHECK-NEXT: table.size externref_table
; CHECK-NEXT: end_function ; CHECK-NEXT: end_function
%tableptr = getelementptr [0 x %externref], ptr addrspace(1) @externref_table, i32 0, i32 0 %sz = call i32 @llvm.wasm.table.size(ptr addrspace(1) @externref_table)
%sz = call i32 @llvm.wasm.table.size(ptr addrspace(1) %tableptr)
ret i32 %sz ret i32 %sz
} }